From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: Re: sparc64: Build failure due to commit f1600e549b94 (sparc: Make sparc64 use scalable lib/iommu-common.c functions)
Date: Sat, 18 Apr 2015 08:05:10 -0400 [thread overview]
Message-ID: <20150418120510.GB1587@oracle.com> (raw)
In-Reply-To: <20150418054705.GA10746@roeck-us.net>
On (04/17/15 22:47), Guenter Roeck wrote:
> The problem is caused by commit f1600e549b94 ("sparc: Make sparc64
> use scalable lib/iommu-common.c functions"), which introduces
>
> static DEFINE_PER_CPU(unsigned int, iommu_pool_hash);
I have to confess that I'm a little confused about what happened here..
The specific patch (2/3) above should have come from this submission
http://www.spinics.net/lists/sparclinux/msg13786.html
aka
http://patchwork.ozlabs.org/patch/459803/
This does not add any additional defines for iommu_pool_hash.
It also does not have any references to fields like page_table_map_base:
instead, these were switched over to things like:
- *dma_addrp = (iommu->page_table_map_base +
+ *dma_addrp = (iommu->tbl.table_map_base +
((iopte - iommu->page_table) << IO_PAGE_SHIFT));
But when I clone
git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc.git
and do a git show of the commit-id above, I see deltas that
dont make sense (they seem to be from a patchset from somewhere
in the middle of the review chain from the thread).
What am I missing?
--Sowmini
next prev parent reply other threads:[~2015-04-18 12:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 5:47 sparc64: Build failure due to commit f1600e549b94 (sparc: Make sparc64 use scalable lib/iommu-common.c functions) Guenter Roeck
2015-04-18 10:59 ` Sowmini Varadhan
2015-04-18 12:05 ` Sowmini Varadhan [this message]
2015-04-18 18:28 ` Guenter Roeck
2015-04-18 18:38 ` Sowmini Varadhan
2015-04-18 19:27 ` David Miller
2015-04-18 19:40 ` David Miller
2015-04-18 19:44 ` Sowmini Varadhan
2015-04-18 19:55 ` Sowmini Varadhan
2015-04-18 21:41 ` David Miller
2015-04-19 4:13 ` Guenter Roeck
2015-04-19 4:23 ` Guenter Roeck
2015-04-19 10:51 ` Sowmini Varadhan
2015-04-19 18:09 ` David Miller
2015-04-18 19:25 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-04-19 18:36 Fwd: " Sowmini Varadhan
2015-04-20 3:01 ` Michael Ellerman
2015-04-20 5:17 ` Guenter Roeck
2015-04-20 16:25 ` David Miller
2015-04-20 16:44 ` Guenter Roeck
2015-04-20 16:50 ` David Miller
2015-04-21 1:54 ` Michael Ellerman
2015-04-21 2:32 ` Guenter Roeck
2015-04-21 3:25 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418120510.GB1587@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox