From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbbDRRh6 (ORCPT ); Sat, 18 Apr 2015 13:37:58 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52661 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbbDRRhz (ORCPT ); Sat, 18 Apr 2015 13:37:55 -0400 Date: Sat, 18 Apr 2015 18:37:40 +0100 From: Mark Brown To: Koro Chen Cc: robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz, tiwai@suse.de, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, s.hauer@pengutronix.de, galak@codeaurora.org, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Message-ID: <20150418173740.GF26185@sirena.org.uk> References: <1428653649-38200-1-git-send-email-koro.chen@mediatek.com> <1428653649-38200-3-git-send-email-koro.chen@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p8BcnzLwh3ipgLRM" Content-Disposition: inline In-Reply-To: <1428653649-38200-3-git-send-email-koro.chen@mediatek.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p8BcnzLwh3ipgLRM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote: > +/* > + * The MTK AFE unit has a audio interconnect with MTK_AFE_INTERCONN_NUM_INPUT > + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the > + * register/bits to set to connect an input with an output. > + */ > +static const struct mtk_afe_connection > + connections[MTK_AFE_INTERCONN_NUM_INPUT][MTK_AFE_INTERCONN_NUM_OUTPUT] = { > + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10}, > + [0][1] = { .creg = 0x020, .cshift = 16, .sreg = 0x020, .sshift = 26}, What are the constraints on using this - is it one input to one output only or can we do mixing or duplication? The register interface definitely does look like something asking for runtime configuration. It'd also be nice to have less magic numbers in the table, at least for the indexes (which I guess correspond to some of the defines in the headers)? --p8BcnzLwh3ipgLRM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVMpZjAAoJECTWi3JdVIfQF5kH/0dICMWCfhiIwSQjNwp4sqKp b+FKyTCeNM4/1ZJ3Nw/O9jSv+WkXriBbXrMVD7gvpZv4GOaDpcMJg1WI94L5nkdZ uuktldTz8H0QeAtxGvJKHrWlNoLNABrD8a0AlCMM9JUY720RYmum1TIn30HxkYWO t1i0WoI49lrOVwLCGXqtdprPQnnsoS4HkxSLlFUeAFoBJi9ZaiwW17HiCUv2quon spB2KOFqvU4V1oiucLYDqEdWgUiwaQDDVT6Oe4kpIDsJMIo1C1sOul7NspupfXmY SV83UA9RTcYZN3h+Pan4dbTFcIfGjb+dhqEXR6LMN9kkteBrgCUckqSZbb9+eYM= =2Peo -----END PGP SIGNATURE----- --p8BcnzLwh3ipgLRM--