From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753486AbbDSDnN (ORCPT <rfc822;w@1wt.eu>);
	Sat, 18 Apr 2015 23:43:13 -0400
Received: from mail-pd0-f175.google.com ([209.85.192.175]:35835 "EHLO
	mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751984AbbDSDnI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 18 Apr 2015 23:43:08 -0400
Date: Sun, 19 Apr 2015 12:42:02 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Taewoong Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        jolsa@redhat.com
Subject: Re: [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and
 features which get or set a config variable.
Message-ID: <20150419034202.GC10169@danjae.kornet>
References: <1428849889-14145-1-git-send-email-treeze.taeung@gmail.com>
 <1428849889-14145-2-git-send-email-treeze.taeung@gmail.com>
 <20150413065529.GG23913@sejong>
 <6F8981BC-A058-4D84-93FC-B7CB8ADDCC53@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6F8981BC-A058-4D84-93FC-B7CB8ADDCC53@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 18, 2015 at 02:02:17PM +0900, Taewoong Song wrote:
> > On Apr 13, 2015, at 3:55 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> > On Sun, Apr 12, 2015 at 11:44:49PM +0900, Taeung Song wrote:
> >> +static struct config_section *find_config_section(const char *section_name)
> >> +{
> >> +	struct config_section *section_node;
> > 
> > It'd be better to split declaration and function body with a blank line.
> > 
> 
> Does mean it like followed by ?
> 
> +static struct config_section *find_config_section(const char *section_name)
> +
> +{
> +	struct config_section *section_node;
> 
> ,or is it ?  
> 
> +static struct config_section *find_config_section(const char *section_name)
> +{
> +
> +	struct config_section *section_node;

Nope!  I meant

static struct config_section *find_config_section(const char *section_name)
{
	struct config_section *section node
								<-- here
	list_for_each_entry(section_node, &sections, list)
		...
}


> 
> > 
> >> +	list_for_each_entry(section_node, &sections, list)
> >> +		if (!strcmp(section_node->name, section_name))
> >> +			return section_node;
> >> +
> >> +	return NULL;
> >> +}
> >> +
> >> +static struct config_element *find_config_element(const char *subkey
> >> +						  , struct config_section *section_node)

And this is not how we put comma, please change it to

static struct config_element *find_config_element(const char *subkey,
						  struct config_section *section_node)

Ditto for others..

Thanks,
Namhyung