From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751684AbbDTEuy (ORCPT ); Mon, 20 Apr 2015 00:50:54 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:37404 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbbDTEuv (ORCPT ); Mon, 20 Apr 2015 00:50:51 -0400 Date: Mon, 20 Apr 2015 06:50:17 +0200 From: Sascha Hauer To: Mark Brown Cc: Koro Chen , robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz, tiwai@suse.de, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, galak@codeaurora.org, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control Message-ID: <20150420045017.GI6325@pengutronix.de> References: <1428653649-38200-1-git-send-email-koro.chen@mediatek.com> <1428653649-38200-3-git-send-email-koro.chen@mediatek.com> <20150418173740.GF26185@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150418173740.GF26185@sirena.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:40:52 up 34 days, 16:32, 45 users, load average: 0.08, 0.09, 0.12 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 18, 2015 at 06:37:40PM +0100, Mark Brown wrote: > On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote: > > > +/* > > + * The MTK AFE unit has a audio interconnect with MTK_AFE_INTERCONN_NUM_INPUT > > + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the > > + * register/bits to set to connect an input with an output. > > + */ > > +static const struct mtk_afe_connection > > + connections[MTK_AFE_INTERCONN_NUM_INPUT][MTK_AFE_INTERCONN_NUM_OUTPUT] = { > > + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10}, > > + [0][1] = { .creg = 0x020, .cshift = 16, .sreg = 0x020, .sshift = 26}, > > What are the constraints on using this - is it one input to one output > only or can we do mixing or duplication? The register interface > definitely does look like something asking for runtime configuration. > > It'd also be nice to have less magic numbers in the table, at least for > the indexes (which I guess correspond to some of the defines in the > headers)? With defines the above two lines would become something like: #define AFE_CONN0 0x20 #define CONN0_I00_O00_S 0 ... #define CONN0_I00_O00_R 10 ... #define CONN0_I00_O01_s 16 ... #define CONN0_I00_O01_S 26 [0][0] = { .creg = AFE_CONN0, .cshift = CONN0_I00_O00_S, .sreg = AFE_CONN0, .sshift = CONN0_I00_O00_R }, [0][1] = { .creg = AFE_CONN0, .cshift = CONN0_I00_O01_S, .sreg = AFE_CONN0, .sshift = CONN0_I00_O01_S }, For the registers we could use defines, but I think using defines for the shifts doesn't add much value given they are only used once. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |