From: Ingo Molnar <mingo@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
jgross@suse.com, roland@purestorage.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch for 4.0] x86: silence warning in /dev/mem support
Date: Mon, 20 Apr 2015 08:52:35 +0200 [thread overview]
Message-ID: <20150420065235.GA13876@gmail.com> (raw)
In-Reply-To: <20150417084846.GB13741@amd>
* Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> > > CC arch/x86/mm/ioremap.o
> > > arch/x86/mm/ioremap.c: In function ‘xlate_dev_mem_ptr’:
> > > arch/x86/mm/ioremap.c:363:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > > addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK));
> > > ^
> > > LD arch/x86/mm/built-in.o
> > >
> > > pavel@amd:/data/l/linux$ gcc --version
> > > gcc (Debian 4.9.2-10) 4.9.2
> >
> > So this code has not been changed for a year or so in theory, and I've
> > never seen this warning with GCC 4.9.1. I'm wondering how it
> > triggered. Could you send me your .config that triggers this?
>
> Config sent in private email. 32-bit kernel.
Ah, I see, the key is:
CONFIG_HIGHMEM64G=y
and neither x86 defconfig nor allyesconfig/allmodconfig selects
HIGHMEM64G apparently, so this was rarely triggered.
Thanks,
Ingo
next prev parent reply other threads:[~2015-04-20 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 8:04 [patch for 4.0] x86: silence warning in /dev/mem support Pavel Machek
2015-04-16 10:09 ` Ingo Molnar
2015-04-16 10:15 ` Pavel Machek
2015-04-17 8:39 ` Ingo Molnar
2015-04-17 8:48 ` Pavel Machek
2015-04-20 6:52 ` Ingo Molnar [this message]
2015-04-20 10:13 ` [tip:x86/urgent] x86/mm: Clean up types in xlate_dev_mem_ptr() tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420065235.GA13876@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=roland@purestorage.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).