From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui
Date: Mon, 20 Apr 2015 10:20:02 +0200 [thread overview]
Message-ID: <20150420082002.GA9872@krava.redhat.com> (raw)
In-Reply-To: <1429416255-12070-4-git-send-email-namhyung@kernel.org>
On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote:
> Since perf diff only support stdio output, TUI fields are only accessed
> from perf report (or perf top). So add new struct hist_entry_tui and
> move those fields into them. And include it as an union member.
>
SNIP
>
> - /* XXX These two should move to some tree widget lib */
> - u16 row_offset;
> - u16 nr_rows;
> -
> bool init_have_children;
> char level;
> u8 filtered;
> + union {
> + struct hist_entry_diff diff;
> + struct hist_entry_tui tui;
> + };
could you please add the comment from changelog in here,
so it's easy to figure this out in the future
thanks,
jirka
next prev parent reply other threads:[~2015-04-20 8:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 4:04 [PATCHSET 0/7] perf tools: Assorted cleanup for TUI (v1) Namhyung Kim
2015-04-19 4:04 ` [PATCH 1/7] perf tools: Get rid of position field from struct hist_entry Namhyung Kim
2015-05-06 2:55 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2015-04-19 4:04 ` [PATCH 2/7] perf diff: Make hist_entry_diff fields union Namhyung Kim
2015-05-06 2:55 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-19 4:04 ` [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui Namhyung Kim
2015-04-20 8:20 ` Jiri Olsa [this message]
2015-04-20 12:10 ` Namhyung Kim
2015-04-19 4:04 ` [PATCH 4/7] perf tools: Move init_have_children field " Namhyung Kim
2015-04-19 4:04 ` [PATCH 5/7] perf hists browser: Fix possible memory leak Namhyung Kim
2015-04-20 8:24 ` Jiri Olsa
2015-04-20 12:13 ` Namhyung Kim
2015-04-19 4:04 ` [PATCH 6/7] perf hists browser: Split popup menu actions Namhyung Kim
2015-04-20 9:21 ` Jiri Olsa
2015-04-20 12:21 ` Namhyung Kim
2015-04-20 9:46 ` Jiri Olsa
2015-04-20 12:25 ` Namhyung Kim
2015-04-20 14:00 ` Arnaldo Carvalho de Melo
2015-04-20 15:22 ` Namhyung Kim
2015-04-20 21:28 ` Arnaldo Carvalho de Melo
2015-04-21 6:10 ` Namhyung Kim
2015-04-19 4:04 ` [PATCH 7/7] perf hists browser: Simplify zooming code a bit Namhyung Kim
2015-04-20 14:02 ` [PATCHSET 0/7] perf tools: Assorted cleanup for TUI (v1) Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2015-04-20 13:00 [PATCHSET 0/7] perf tools: Assorted cleanup for TUI (v2) Namhyung Kim
2015-04-20 13:00 ` [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui Namhyung Kim
2015-04-20 19:44 ` Arnaldo Carvalho de Melo
2015-04-21 6:34 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420082002.GA9872@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).