Re: [PATCH] Staging: dgnc: fixed code style issue

Dan Carpenter
2015-04-20T08:14:07Z

On Sun, Apr 19, 2015 at 09:18:23PM +0200, Yorick Rommers wrote:
> A patch for a line being too long (>80) in dgnc_mgmt.c,
> fixed by making a temporary value for dgnc_Board[brd], and removing
> an unnecessary typecast.
>
> Signed-off-by: Yorick Rommers <yorick-rommers@hotmail.com>
> ---
> drivers/staging/dgnc/dgnc_mgmt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
> index b13318a..0e75d37 100644
> --- a/drivers/staging/dgnc/dgnc_mgmt.c
> +++ b/drivers/staging/dgnc/dgnc_mgmt.c
> @@ -143,12 +143,14 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> di.info_bdnum = brd;
>
> spin_lock_irqsave(&dgnc_Board[brd]->bd_lock, flags);
> + struct dgnc_board *bd = dgnc_Board[brd];

Change the others as well.

>
> di.info_bdtype = dgnc_Board[brd]->dpatype;

di.info_bdtype = bd->dpatype;

> di.info_bdstate = dgnc_Board[brd]->dpastatus;

di.info_bdstate = bd->dpastatus;

> di.info_ioport = 0;
> di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
> - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
> + di.info_physsize = bd->membase - bd->membase_end;
> +
> if (dgnc_Board[brd]->state != BOARD_FAILED)
> di.info_nports = dgnc_Board[brd]->nasync;
^^^^^^^^^^^^^^^
Etc.

regards,
dan carpenter