Re: [PATCH 13/49] writeback: move bandwidth related fields from backing_dev_info into bdi_writeback

Tejun Heo
2015-04-20T18:01:28Z

On Mon, Apr 20, 2015 at 05:09:50PM +0200, Jan Kara wrote:
> On Mon 06-04-15 15:58:02, Tejun Heo wrote:
> > Currently, a bdi (backing_dev_info) embeds single wb (bdi_writeback)
> > and the role of the separation is unclear. For cgroup support for
> > writeback IOs, a bdi will be updated to host multiple wb's where each
> > wb serves writeback IOs of a different cgroup on the bdi. To achieve
> > that, a wb should carry all states necessary for servicing writeback
> > IOs for a cgroup independently.
> >
> > This patch moves bandwidth related fields from backing_dev_info into
> > bdi_writeback.
> >
> > * The moved fields are: bw_time_stamp, dirtied_stamp, written_stamp,
> > write_bandwidth, avg_write_bandwidth, dirty_ratelimit,
> > balanced_dirty_ratelimit, completions and dirty_exceeded.
> >
> > * writeback_chunk_size() and over_bgroup_thresh() now take @wb instead
> > of @bdi.
> ^^^ over_bground_thresh()
>
> Otherwise the patch looks good to me. You can add:

Updated accordingly.

> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks.

--
tejun