From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755463AbbDTSWF (ORCPT ); Mon, 20 Apr 2015 14:22:05 -0400 Received: from mail-qg0-f45.google.com ([209.85.192.45]:34561 "EHLO mail-qg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbbDTSV5 (ORCPT ); Mon, 20 Apr 2015 14:21:57 -0400 Date: Mon, 20 Apr 2015 14:21:53 -0400 From: Tejun Heo To: Jan Kara Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com Subject: Re: [PATCH 18/49] bdi: make inode_to_bdi() inline Message-ID: <20150420182153.GE4206@htj.duckdns.org> References: <1428350318-8215-1-git-send-email-tj@kernel.org> <1428350318-8215-19-git-send-email-tj@kernel.org> <20150420154050.GH17020@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420154050.GH17020@quack.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 05:40:50PM +0200, Jan Kara wrote: > > This patch makes inode_to_bdi() and sb_is_blkdev_sb() that the > > function calls inline. blockdev_superblock and noop_backing_dev_info > > are EXPORT_GPL'd to allow the inline functions to be used from > > modules. > I somewhat hate making blockdev_superblock exported just for this. But > OK. Hopefully people won't get creative with it. > > While at it, maske sb_is_blkdev_sb() return bool instead of int. > ^^^ make Updated. > Otherwise the patch looks good. You can add: > Reviewed-by: Jan Kara Thanks. -- tejun