From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752341AbbDTUKL (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Apr 2015 16:10:11 -0400
Received: from mail.kernel.org ([198.145.29.136]:36582 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750771AbbDTUKJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Apr 2015 16:10:09 -0400
Date: Mon, 20 Apr 2015 17:09:36 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, David Ahern <dsahern@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [RFC 0/6] perf tools: Report event parsing errors
Message-ID: <20150420200936.GM11111@kernel.org>
References: <1429377946-2147-1-git-send-email-jolsa@kernel.org>
 <20150418173927.GA5897@gmail.com>
 <20150418204258.GA26943@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150418204258.GA26943@krava.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sat, Apr 18, 2015 at 10:42:58PM +0200, Jiri Olsa escreveu:
> On Sat, Apr 18, 2015 at 07:39:27PM +0200, Ingo Molnar wrote:
> > So since we now know exactly what's going on, we might want to drop 
> > the 'invalid or unsupported event' language as well, and make it 
> > specific:
> > 
> >    $ ./perf record -e 'cpu/even=0x1/' ls
> >    event syntax error: 'cpu/even=0x1/'
> >                             \___ unknown term
> >  
> > 
> > ?
> 
> ok
> 
> > 
> > Also, for the above error, could we easily list the valid terms? An 
> > error like:
> > 
> >    $ ./perf record -e 'cpu/even=0x1/' ls
> >    event syntax error: 'cpu/even=0x1/'
> >                             \___ unknown term
> >    valid terms: "event", "raw".
> > 
> > or so?
> 
> we already carry list of all terms for given pmu,
> so it shouldn't be a problem

So, do you want me to apply this series and you work on top of it or
should I wait for another that implements what Ingo suggested?

Also, we have:

[root@zoo ~]# perf stat --all -e cycles usleep 1

 Performance counter stats for 'system wide':

         3,382,595      cycles                                                      

       0.001739102 seconds time elapsed

[root@zoo ~]# perf stat --all-cpus -e cycles usleep 1

 Performance counter stats for 'system wide':

         2,435,672      cycles                                                      

       0.001191689 seconds time elapsed

[root@zoo ~]# perf stat --a -e cycles usleep 1
  Error: Ambiguous option: a (could be --no-no-aggr or --append)

 usage: perf stat [<options>] [<command>]

[root@zoo ~]#

Which is nice, wouldn't it be good to have it for the that as well, i.e.
for your example "ev=" would be a valid, and shorter form of "even=" or
"event=".

- Arnaldo