From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463AbbDTUwv (ORCPT ); Mon, 20 Apr 2015 16:52:51 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38918 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbbDTUwr (ORCPT ); Mon, 20 Apr 2015 16:52:47 -0400 Date: Mon, 20 Apr 2015 21:52:30 +0100 From: Mark Brown To: Sascha Hauer Cc: Koro Chen , robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz, tiwai@suse.de, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, galak@codeaurora.org, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Message-ID: <20150420205230.GK14892@sirena.org.uk> References: <1428653649-38200-1-git-send-email-koro.chen@mediatek.com> <1428653649-38200-3-git-send-email-koro.chen@mediatek.com> <20150418173740.GF26185@sirena.org.uk> <20150420045017.GI6325@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3CAnR4CLEnEWqRMR" Content-Disposition: inline In-Reply-To: <20150420045017.GI6325@pengutronix.de> X-Cookie: Everyone hates me because I'm paranoid. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3CAnR4CLEnEWqRMR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 20, 2015 at 06:50:17AM +0200, Sascha Hauer wrote: > On Sat, Apr 18, 2015 at 06:37:40PM +0100, Mark Brown wrote: > > On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote: > > > + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10}, > > > + [0][1] = { .creg = 0x020, .cshift = 16, .sreg = 0x020, .sshift = 26}, > > It'd also be nice to have less magic numbers in the table, at least for > > the indexes (which I guess correspond to some of the defines in the > > headers)? > With defines the above two lines would become something like: > [0][0] = { .creg = AFE_CONN0, .cshift = CONN0_I00_O00_S, .sreg = AFE_CONN0, .sshift = CONN0_I00_O00_R }, > [0][1] = { .creg = AFE_CONN0, .cshift = CONN0_I00_O01_S, .sreg = AFE_CONN0, .sshift = CONN0_I00_O01_S }, > For the registers we could use defines, but I think using defines for > the shifts doesn't add much value given they are only used once. By indexes I actually meant the [0][0] and so on - they seem the more magic bit. --3CAnR4CLEnEWqRMR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVNWcNAAoJECTWi3JdVIfQWJQH/jaJOqXbcGyS2jBWSjHJsKu4 IoYzOs1j8P93OccaxiF22jNqjQLyYZ/CJRlwAPsKolPu57hReFklvzEbf/lbGZUf 08R3KrSUBvhwdGJWm5OXF3f8flaZ/v47XsU+KwDscbrGBEU4S1PDnfq7B0nvlfM/ 4ZqaZPHtHMOgfo5aYi6zifkILLqf1vG2mOx1yiOrUx0jP3H/7WN7hSSUHZS10+HF BdnWu/8CY3N0tel3oC5nMxp0Uh6Glx+CuGOPDR3O1ZwgLV96WytaZSj/TTfjqwbx WozW9HJ8ETH6PNSOTWv3PfHwsXBAgtuIpDOnZxpl0l/aWFslWJ/K7Wi0Z9LamFE= =aVHV -----END PGP SIGNATURE----- --3CAnR4CLEnEWqRMR--