From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754191AbbDTVZm (ORCPT ); Mon, 20 Apr 2015 17:25:42 -0400 Received: from mail.kernel.org ([198.145.29.136]:40811 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbbDTVZj (ORCPT ); Mon, 20 Apr 2015 17:25:39 -0400 Date: Mon, 20 Apr 2015 18:25:35 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: David Ahern , Namhyung Kim , LKML Subject: Re: perf/tracepoints access to interpreted strings Message-ID: <20150420212535.GS11111@kernel.org> References: <552E8FB8.6010005@gmail.com> <20150415180927.GR16027@kernel.org> <20150420164616.4227fae9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420164616.4227fae9@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Apr 20, 2015 at 04:46:16PM -0400, Steven Rostedt escreveu: > On Wed, 15 Apr 2015 15:09:27 -0300 > Arnaldo Carvalho de Melo wrote: > > If it is strictly an enum, i.e. no holes and just by looking at the > > "format" file above I don't see how it could have holes, albeit enums > > may have, we can as well have this: > > const char *perf_evsel__enum(struct perf_evsel *evsel, > > struct perf_sample *sample, > > const char *enum_name); > > That would return an array of strings that you could directly access, > > indexing using some of the fields. > > I.e. internally we would see the tracepoint format file as: > > field:enum action vec; offset:12; size:4; signed:0; > > enum: action: TIMER, NET_TX, NET_RX, BLOCK, BLOCK_IOPOLL, TASKLET, SCHED, HRTIMER, RCU > Note, with the new TRACE_DEFINE_ENUM() that was already added to > Linus's tree, that print_fmt now looks like: > print fmt: "vec=%u [action=%s]", REC->vec, __print_symbolic(REC->vec, > { 0, "HI" }, { 1, "TIMER" }, { 2, "NET_TX" }, { 3, "NET_RX" }, { 4, "BLOCK" }, > { 5, "BLOCK_IOPOLL" }, { 6, "TASKLET" }, { 7, "SCHED" }, { 8, "HRTIMER" }, > { 9, "RCU" }) That is better, indeed, covers holes :-) - Arnaldo