From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752900AbbDUGXJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Apr 2015 02:23:09 -0400
Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:55106 "EHLO
	lgemrelse7q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752019AbbDUGXG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Apr 2015 02:23:06 -0400
X-Original-SENDERIP: 10.177.220.203
X-Original-MAILFROM: namhyung@kernel.org
Date: Tue, 21 Apr 2015 15:17:56 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: perf/tracepoints access to interpreted strings
Message-ID: <20150421061756.GC1905@sejong>
References: <552E8FB8.6010005@gmail.com>
 <20150415180927.GR16027@kernel.org>
 <20150420164616.4227fae9@gandalf.local.home>
 <20150420212535.GS11111@kernel.org>
 <55356F20.2090706@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <55356F20.2090706@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On Mon, Apr 20, 2015 at 03:26:56PM -0600, David Ahern wrote:
> On 4/20/15 3:25 PM, Arnaldo Carvalho de Melo wrote:
> >Em Mon, Apr 20, 2015 at 04:46:16PM -0400, Steven Rostedt escreveu:
> >>On Wed, 15 Apr 2015 15:09:27 -0300
> >>Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >>>If it is strictly an enum, i.e. no holes and just by looking at the
> >>>"format" file above I don't see how it could have holes, albeit enums
> >>>may have, we can as well have this:
> >
> >>>	const char *perf_evsel__enum(struct perf_evsel *evsel,
> >>>				     struct perf_sample *sample,
> >>>				     const char *enum_name);
> >
> >>>That would return an array of strings that you could directly access,
> >>>indexing using some of the fields.
> >
> >>>I.e. internally we would see the tracepoint format file as:
> >
> >>>  	field:enum action vec;	offset:12;	size:4;	signed:0;
> >
> >>>	enum: action: TIMER, NET_TX, NET_RX, BLOCK, BLOCK_IOPOLL, TASKLET, SCHED, HRTIMER, RCU
> >
> >>Note, with the new TRACE_DEFINE_ENUM() that was already added to
> >>Linus's tree, that print_fmt now looks like:
> >
> >>print fmt: "vec=%u [action=%s]", REC->vec, __print_symbolic(REC->vec,
> >>  { 0, "HI" }, { 1, "TIMER" }, { 2, "NET_TX" }, { 3, "NET_RX" }, { 4, "BLOCK" },
> >>  { 5, "BLOCK_IOPOLL" }, { 6, "TASKLET" }, { 7, "SCHED" }, { 8, "HRTIMER" },
> >>  { 9, "RCU" })
> >
> >That is better, indeed, covers holes :-)
> 
> Seems to me that means 2 different implementations are needed ... old and
> new.

I just called pevent_event_info() and parsed the output seq.buffer for
my perf kmem work to parse GFP flags.

Thanks,
Namhyung