From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754570AbbDUHkY (ORCPT ); Tue, 21 Apr 2015 03:40:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49245 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754520AbbDUHkU (ORCPT ); Tue, 21 Apr 2015 03:40:20 -0400 Date: Tue, 21 Apr 2015 09:40:15 +0200 From: Greg KH To: Jaime Arrocha Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gdm72xx: enclose complex define statement Message-ID: <20150421074015.GA10367@kroah.com> References: <20150421031150.GA20462@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150421031150.GA20462@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 10:11:51PM -0500, Jaime Arrocha wrote: > This patch fixes the warning found by checkpatch.pl: > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Jaime Arrocha > --- > drivers/staging/gdm72xx/usb_ids.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/gdm72xx/usb_ids.h b/drivers/staging/gdm72xx/usb_ids.h > index 8ce544d..2b50ac6 100644 > --- a/drivers/staging/gdm72xx/usb_ids.h > +++ b/drivers/staging/gdm72xx/usb_ids.h > @@ -32,8 +32,8 @@ > #define BL_PID_MASK 0xffc0 > > #define USB_DEVICE_BOOTLOADER(vid, pid) \ > - {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)}, \ > - {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)} > + ({USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)}, \ > + {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)}) checkpatch isn't always correct. This is one such example. Does this even compile?