public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Marek Belisko <marek@goldelico.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org, corbet@lwn.net,
	linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, gta04-owner@goldelico.com,
	"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v2] Documentation usb serial: fixed how to provide vendor and product id
Date: Tue, 21 Apr 2015 09:47:23 +0200	[thread overview]
Message-ID: <20150421074723.GA27057@localhost> (raw)
In-Reply-To: <1429560920-22620-1-git-send-email-marek@goldelico.com>

On Mon, Apr 20, 2015 at 10:15:20PM +0200, Marek Belisko wrote:
> From: "H. Nikolaus Schaller" <hns@goldelico.com>
> 
> While trying to test a Cinterion GSM/GPS/3G module I had reconfigured
> the USB interface by mistake and therefore needed to run a different
> USB driver than CDC-ACM. It turned out that I need the "usbserial" driver.
> 
> This file is an official description how to use it: Documentation/usb/usb-serial.txt
> 
> But it is outdated. The parameters vendor= and product= are only available
> if compiled as a kernel module and have been superseded by a /sys interface.
> 
> Here was the solution:
> 
> https://bbs.archlinux.org/viewtopic.php?id=175499
> 
>   insmod usbserial vendor=0x#### product=0x####
> 
> becomes (first #### is vendor, second is product)
> 
>   modprobe usbserial
>   echo #### #### >/sys/bus/usb-serial/drivers/generic/new_id
> 
> This patch changes the documentation file to describe the modern variant.
> Please note that the old one still works (if compiled as module).
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> 
> - fixed 2 sentences suggested by Johan Hovold

Thanks for fixing this. Looks good now.

Acked-by: Johan Hovold <johan@kernel.org>

Johan

  reply	other threads:[~2015-04-21  7:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 20:09 [PATCH v2] Documentation usb serial: fixed how to provide vendor and product id Marek Belisko
2015-04-14  7:30 ` Johan Hovold
2015-04-20 20:15 ` Marek Belisko
2015-04-21  7:47   ` Johan Hovold [this message]
2015-04-21 11:57     ` Bjørn Mork
2015-04-21 13:03       ` Johan Hovold
2015-05-07 15:45         ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150421074723.GA27057@localhost \
    --to=johan@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=gta04-owner@goldelico.com \
    --cc=hns@goldelico.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marek@goldelico.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox