* [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
@ 2015-04-20 2:59 Gbenga Adalumo
2015-04-20 14:43 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Gbenga Adalumo @ 2015-04-20 2:59 UTC (permalink / raw)
To: gbengadev, abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel
Fix coding style errors found by checkpatch.pl tool
Signed-off-by: Gbenga Adalumo <gbengadev@gmail.com>
---
drivers/staging/comedi/drivers/daqboard2000.c | 58 +++++++++++++--------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
index f97d18d..2ca8d3e 100644
--- a/drivers/staging/comedi/drivers/daqboard2000.c
+++ b/drivers/staging/comedi/drivers/daqboard2000.c
@@ -40,10 +40,10 @@ Configuration options: not applicable, uses PCI auto config
for the card, and here are the findings so far.
1. A good document that describes the PCI interface chip is 9080db-106.pdf
- available from http://www.plxtech.com/products/io/pci9080
+ available from http://www.plxtech.com/products/io/pci9080
2. The initialization done so far is:
- a. program the FPGA (windows code sans a lot of error messages)
+ a. program the FPGA (windows code sans a lot of error messages)
b.
3. Analog out seems to work OK with DAC's disabled, if DAC's are enabled,
@@ -52,52 +52,52 @@ Configuration options: not applicable, uses PCI auto config
gives me no clues. I'll keep it simple so far.
4. Analog in.
- Each channel in the scanlist seems to be controlled by four
+ Each channel in the scanlist seems to be controlled by four
control words:
- Word0:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ Word0:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- Word1:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ Word1:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| | | | | | |
- +------+------+ | | | | +-- Digital input (??)
+ +------+------+ | | | | +-- Digital input (??)
| | | | +---- 10 us settling time
| | | +------ Suspend acquisition (last to scan)
| | +-------- Simultaneous sample and hold
| +---------- Signed data format
+------------------------- Correction offset low
- Word2:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- | | | | | | | | | |
- +-----+ +--+--+ +++ +++ +--+--+
- | | | | +----- Expansion channel
+ Word2:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ | | | | | | | | | |
+ +-----+ +--+--+ +++ +++ +--+--+
+ | | | | +----- Expansion channel
| | | +----------- Expansion gain
- | | +--------------- Channel (low)
+ | | +--------------- Channel (low)
| +--------------------- Correction offset high
+----------------------------- Correction gain low
- Word3:
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- ! | | | ! | | | ! | | | ! | | | !
- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
- | | | | | | | | |
- +------+------+ | | +-+-+ | | +-- Low bank enable
- | | | | | +---- High bank enable
- | | | | +------ Hi/low select
+ Word3:
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ ! | | | ! | | | ! | | | ! | | | !
+ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ | | | | | | | | |
+ +------+------+ | | +-+-+ | | +-- Low bank enable
+ | | | | | +---- High bank enable
+ | | | | +------ Hi/low select
| | | +---------- Gain (1,?,2,4,8,16,32,64)
| | +-------------- differential/single ended
| +---------------- Unipolar
+------------------------- Correction gain high
999. The card seems to have an incredible amount of capabilities, but
- trying to reverse engineer them from the Windows source is beyond my
+ trying to reverse engineer them from the Windows source is beyond my
patience.
*/
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
2015-04-20 2:59 [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c Gbenga Adalumo
@ 2015-04-20 14:43 ` Greg KH
2015-04-21 2:57 ` Gbenga Adalumo
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2015-04-20 14:43 UTC (permalink / raw)
To: Gbenga Adalumo; +Cc: abbotti, hsweeten, devel, linux-kernel
On Sun, Apr 19, 2015 at 07:59:31PM -0700, Gbenga Adalumo wrote:
> Fix coding style errors found by checkpatch.pl tool
What errors? Be specific.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
2015-04-20 14:43 ` Greg KH
@ 2015-04-21 2:57 ` Gbenga Adalumo
2015-04-21 7:50 ` Greg KH
2015-04-21 9:09 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Gbenga Adalumo @ 2015-04-21 2:57 UTC (permalink / raw)
To: Greg KH; +Cc: Ian Abbott, hsweeten, devel, linux-kernel
The patch fixes a trailing whitespace and code indenting coding style
errors as reported by checkpatch.pl tool.
Details of the lines where the fixed errors were reported are as follows:
drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace
drivers/staging/comedi/drivers/daqboard2000.c:46: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:55: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:58: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:59: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:60: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:61: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:63: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:64: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:65: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:66: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:68: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:75: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:76: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:77: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:78: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:79: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:80: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:81: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:83: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:86: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:87: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:88: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:89: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:90: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:91: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:92: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:93: ERROR: code indent
should use tabs where possible
drivers/staging/comedi/drivers/daqboard2000.c:100: ERROR: code indent
should use tabs where possible
--Gbenga Adalumo
On Mon, Apr 20, 2015 at 7:43 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Apr 19, 2015 at 07:59:31PM -0700, Gbenga Adalumo wrote:
>> Fix coding style errors found by checkpatch.pl tool
>
> What errors? Be specific.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
2015-04-21 2:57 ` Gbenga Adalumo
@ 2015-04-21 7:50 ` Greg KH
2015-04-21 9:14 ` Ian Abbott
2015-04-21 9:09 ` Dan Carpenter
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2015-04-21 7:50 UTC (permalink / raw)
To: Gbenga Adalumo; +Cc: devel, Ian Abbott, linux-kernel
On Mon, Apr 20, 2015 at 07:57:31PM -0700, Gbenga Adalumo wrote:
> The patch fixes a trailing whitespace and code indenting coding style
> errors as reported by checkpatch.pl tool.
> Details of the lines where the fixed errors were reported are as follows:
>
> drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace
> drivers/staging/comedi/drivers/daqboard2000.c:46: ERROR: code indent
> should use tabs where possible
<snip>
You don't have to list all of the individual errors, and not in a
line-wrapped way either.
It looks like you are fixing different types of errors, so please
provide different patches to do them. Each patch should just do one
thing.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
2015-04-21 2:57 ` Gbenga Adalumo
2015-04-21 7:50 ` Greg KH
@ 2015-04-21 9:09 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-04-21 9:09 UTC (permalink / raw)
To: Gbenga Adalumo; +Cc: Greg KH, devel, Ian Abbott, linux-kernel
Oh. Ok. Resend with a corrected changelog then.
But don't include all the spammy output just one or two lines or a
summary.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
2015-04-21 7:50 ` Greg KH
@ 2015-04-21 9:14 ` Ian Abbott
0 siblings, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2015-04-21 9:14 UTC (permalink / raw)
To: Greg KH, Gbenga Adalumo; +Cc: devel, linux-kernel
On 21/04/15 08:50, Greg KH wrote:
> On Mon, Apr 20, 2015 at 07:57:31PM -0700, Gbenga Adalumo wrote:
>> The patch fixes a trailing whitespace and code indenting coding style
>> errors as reported by checkpatch.pl tool.
>> Details of the lines where the fixed errors were reported are as follows:
>>
>> drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace
>> drivers/staging/comedi/drivers/daqboard2000.c:46: ERROR: code indent
>> should use tabs where possible
>
> <snip>
>
> You don't have to list all of the individual errors, and not in a
> line-wrapped way either.
>
> It looks like you are fixing different types of errors, so please
> provide different patches to do them. Each patch should just do one
> thing.
All these "errors" occur in a single block comment. It would be
preferable if that block comment were reformatted to use the usual
block-comment style:
/*
* blah
* blah
*/
This has already been done for some comedi drivers.
Thanks,
Ian A.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-21 9:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-20 2:59 [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c Gbenga Adalumo
2015-04-20 14:43 ` Greg KH
2015-04-21 2:57 ` Gbenga Adalumo
2015-04-21 7:50 ` Greg KH
2015-04-21 9:14 ` Ian Abbott
2015-04-21 9:09 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox