From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: infinipath@intel.com, roland@kernel.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
luto@amacapital.net, mst@redhat.com,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"Toshi Kani" <toshi.kani@hp.com>,
"Rickard Strandqvist" <rickard_strandqvist@spectrumdigital.se>,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
"Roland Dreier" <roland@purestorage.com>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
"Suresh Siddha" <sbsiddha@gmail.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Juergen Gross" <jgross@suse.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dave Airlie" <airlied@redhat.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Antonino Daplas" <adaplas@gmail.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Stefan Bader" <stefan.bader@canonical.com>,
konrad.wilk@oracle.com, ville.syrjala@linux.intel.com,
david.vrabel@citrix.com, jbeulich@suse.com,
"Roger Pau Monné" <roger.pau@citrix.com>,
linux-fbdev@vger.kernel.org, xen-devel@lists.xensource.com
Subject: Re: [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()
Date: Tue, 21 Apr 2015 16:17:18 -0600 [thread overview]
Message-ID: <20150421221718.GA10836@obsidianresearch.com> (raw)
In-Reply-To: <1429653035-19424-3-git-send-email-mcgrof@do-not-panic.com>
On Tue, Apr 21, 2015 at 02:50:35PM -0700, Luis R. Rodriguez wrote:
> - if (qib_wc_pat) {
> - resource_size_t vl15off;
> - /*
> - * We do not set WC on the VL15 buffers to avoid
> - * a rare problem with unaligned writes from
> - * interrupt-flushed store buffers, so we need
> - * to map those separately here. We can't solve
> - * this for the rarely used mtrr case.
> - */
> - ret = init_chip_wc_pat(dd, 0);
> - if (ret)
> - goto bail;
> + /*
> + * We do not set WC on the VL15 buffers to avoid
> + * a rare problem with unaligned writes from
> + * interrupt-flushed store buffers, so we need
> + * to map those separately here. We can't solve
> + * this for the rarely used mtrr case.
> + */
This is a small change in behavior, but it doesn't seem important..
Mike, what do you think about adding:
if (dd->wc_cookie)
dev_err(.., "Using this device without CPU PAT support is known to be broken");
or similar..
Jason
next prev parent reply other threads:[~2015-04-21 22:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 21:50 [PATCH v4 0/2] qib: few changes to bury MTRR use Luis R. Rodriguez
2015-04-21 21:50 ` [PATCH v4 1/2] IB/qib: add acounting for MTRR Luis R. Rodriguez
2015-04-22 13:44 ` Doug Ledford
2015-04-22 15:28 ` Luis R. Rodriguez
2015-04-21 21:50 ` [PATCH v4 2/2] IB/qib: use arch_phys_wc_add() Luis R. Rodriguez
2015-04-21 22:17 ` Jason Gunthorpe [this message]
2015-04-22 13:54 ` Doug Ledford
2015-04-22 15:33 ` Luis R. Rodriguez
2015-04-22 16:57 ` Doug Ledford
2015-04-22 17:37 ` Luis R. Rodriguez
2015-04-22 17:48 ` Doug Ledford
2015-04-22 18:32 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421221718.GA10836@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=adaplas@gmail.com \
--cc=airlied@redhat.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=cocci@systeme.lip6.fr \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=david.vrabel@citrix.com \
--cc=dennis.dalessandro@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mike.marciniszyn@intel.com \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=plagnioj@jcrosoft.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=roger.pau@citrix.com \
--cc=roland@kernel.org \
--cc=roland@purestorage.com \
--cc=sbsiddha@gmail.com \
--cc=sean.hefty@intel.com \
--cc=stefan.bader@canonical.com \
--cc=tglx@linutronix.de \
--cc=tomi.valkeinen@ti.com \
--cc=toshi.kani@hp.com \
--cc=ville.syrjala@linux.intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox