From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965298AbbDUXqy (ORCPT ); Tue, 21 Apr 2015 19:46:54 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43354 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965191AbbDUXqv (ORCPT ); Tue, 21 Apr 2015 19:46:51 -0400 Date: Wed, 22 Apr 2015 01:46:50 +0200 From: Alexandre Belloni To: Juergen Borleis Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, kernel@pengutronix.de, Alessandro Zummo , linux-arm-kernel@lists.infradead.org, Robert Schwebel Subject: Re: [rtc-linux] [PATCH 2/5] RTC/i.MX/DryIce: add the unit recovery code Message-ID: <20150421234649.GG8539@piout.net> References: <1429002716-19821-1-git-send-email-jbe@pengutronix.de> <1429002716-19821-3-git-send-email-jbe@pengutronix.de> <20150421231411.GC8539@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150421231411.GC8539@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/04/2015 at 01:14:11 +0200, Alexandre Belloni wrote : > > + sec = __raw_readl(imxdi->ioaddr + DTCMR); > > + if (sec != 0) > > + dev_warn(&imxdi->pdev->dev, > > + "The security violation has happend at %u seconds\n", > > Further improvement for this driver: use both DTCMR and DTCLR to be year > 2038 proof Please forget that comment I just realized that seconds were counted in the most significant part... -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com