From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754267AbbDVBS2 (ORCPT ); Tue, 21 Apr 2015 21:18:28 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:36513 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753440AbbDVBS1 (ORCPT ); Tue, 21 Apr 2015 21:18:27 -0400 Date: Tue, 21 Apr 2015 18:18:21 -0700 From: "Paul E. McKenney" To: Pranith Kumar Cc: Andrew Morton , Michal Hocko , Josh Triplett , Johannes Weiner , Geert Uytterhoeven , Bertrand Jacquin , "Luis R. Rodriguez" , Andy Lutomirski , Clark Williams , open list Subject: Re: [RFC PATCH] rcu: config: Remove prompt for RCU implementation Message-ID: <20150422011821.GR5561@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1429651783-7754-1-git-send-email-bobby.prani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429651783-7754-1-git-send-email-bobby.prani@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15042201-0021-0000-0000-000009FB3FCE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2015 at 05:29:42PM -0400, Pranith Kumar wrote: > The RCU implementation which is chosen is dependent on PREEMPT and SMP config > options and is not really a user-selectable choice. The following change will > remove the menu entry and will be derived from the above two options. > > Signed-off-by: Pranith Kumar Hmmm... I guess that there isn't much point in calling something a "choice" when it hasn't really been a choice for quite a few years now. I queued this, and have started testing it. Thanx, Paul > --- > init/Kconfig | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 0b37750..7707e4a 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -463,13 +463,9 @@ endmenu # "CPU/Task time and stats accounting" > > menu "RCU Subsystem" > > -choice > - prompt "RCU Implementation" > - default TREE_RCU > - > config TREE_RCU > - bool "Tree-based hierarchical RCU" > - depends on !PREEMPT && SMP > + bool > + default y if !PREEMPT && SMP > help > This option selects the RCU implementation that is > designed for very large SMP system with hundreds or > @@ -477,8 +473,8 @@ config TREE_RCU > smaller systems. > > config PREEMPT_RCU > - bool "Preemptible tree-based hierarchical RCU" > - depends on PREEMPT > + bool > + default y if PREEMPT > help > This option selects the RCU implementation that is > designed for very large SMP systems with hundreds or > @@ -489,16 +485,14 @@ config PREEMPT_RCU > Select this option if you are unsure. > > config TINY_RCU > - bool "UP-only small-memory-footprint RCU" > - depends on !PREEMPT && !SMP > + bool > + default y if !PREEMPT && !SMP > help > This option selects the RCU implementation that is > designed for UP systems from which real-time response > is not required. This option greatly reduces the > memory footprint of RCU. > > -endchoice > - > config RCU_EXPERT > bool "Make expert-level adjustments to RCU configuration" > default n > -- > 1.9.1 >