From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933771AbbDVHCU (ORCPT ); Wed, 22 Apr 2015 03:02:20 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34731 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933681AbbDVHCT (ORCPT ); Wed, 22 Apr 2015 03:02:19 -0400 Date: Wed, 22 Apr 2015 16:02:32 +0900 From: Sergey Senozhatsky To: Marcin Jabrzyk Cc: Sergey Senozhatsky , minchan@kernel.org, ngupta@vflare.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, kyungmin.park@samsung.com Subject: Re: [PATCH] zram: remove obsolete ZRAM_DEBUG option Message-ID: <20150422070232.GA3624@swordfish> References: <1429615220-20676-1-git-send-email-m.jabrzyk@samsung.com> <20150421235552.GA1628@swordfish> <55374224.2050803@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55374224.2050803@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/22/15 08:39), Marcin Jabrzyk wrote: > >agree, there is no pr_debug() in the current zram. so the change > >looks good to me. > > > > > >btw, same stands for zsmalloc (for the time being): > > > > #ifdef CONFIG_ZSMALLOC_DEBUG > > #define DEBUG > > #endif > > > >seems to be useless. and there is even no ZSMALLOC_DEBUG config option > >in mm/Kconfig. > I've forgot to add this too in the patch, but I've saw it at some time > earlier. > Anyway I'll prepare v2 with removal of both unused DEBUGs. > > > >so let's return back to it and clean up after the merge window. > I'll send v2 and eventually resend it after merge window closes. a separate patch please. one for zram (Andrew has picked it up already) and one for zsmalloc. -ss > > > > -ss > > > >>Signed-off-by: Marcin Jabrzyk > >>--- > >> drivers/block/zram/Kconfig | 10 +--------- > >> drivers/block/zram/zram_drv.c | 4 ---- > >> 2 files changed, 1 insertion(+), 13 deletions(-) > >> > >>diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig > >>index 6489c0fd0ea6..386ba3d1a6ee 100644 > >>--- a/drivers/block/zram/Kconfig > >>+++ b/drivers/block/zram/Kconfig > >>@@ -23,12 +23,4 @@ config ZRAM_LZ4_COMPRESS > >> default n > >> help > >> This option enables LZ4 compression algorithm support. Compression > >>- algorithm can be changed using `comp_algorithm' device attribute. > >>- > >>-config ZRAM_DEBUG > >>- bool "Compressed RAM block device debug support" > >>- depends on ZRAM > >>- default n > >>- help > >>- This option adds additional debugging code to the compressed > >>- RAM block device driver. > >>+ algorithm can be changed using `comp_algorithm' device attribute. > >>\ No newline at end of file > >>diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > >>index fe67ebbe6c18..ea10f291d722 100644 > >>--- a/drivers/block/zram/zram_drv.c > >>+++ b/drivers/block/zram/zram_drv.c > >>@@ -15,10 +15,6 @@ > >> #define KMSG_COMPONENT "zram" > >> #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > >> > >>-#ifdef CONFIG_ZRAM_DEBUG > >>-#define DEBUG > >>-#endif > >>- > >> #include > >> #include > >> #include > >>-- > >>1.9.1 > >> > > > > Best regards, > -- > Marcin Jabrzyk > Samsung R&D Institute Poland > Samsung Electronics >