public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: revert c72c6160d967ed26a0b136dbab337f821d233509
Date: Wed, 22 Apr 2015 18:58:37 +0900	[thread overview]
Message-ID: <20150422095837.GC3624@swordfish> (raw)

Hello,

could you please revert c72c6160d967ed26a0b136dbab337f821d233509 ?

Commit c72c6160d967 ("zram: move compact_store() to sysfs functions area")
was intended to be a cosmetic change that w/o any functional change and was
part of a bigger change:
  http://lkml.iu.edu/hypermail/linux/kernel/1503.1/01818.html

(so c72c6160d967 removes compaction support).


my bad, we managed to create a mess of patches for 4.1, so Andrew had to
manually pick up and alter some commits. it didn't work well for that one.

so we can either add missing compaction sysfs attr, or revert this change.
Minchan Kim and I prefer to revert this commit
  http://lkml.iu.edu/hypermail/linux/kernel/1504.2/00623.html

since it doesn't add any value to 4.1 per se.


I will re-submit it for 4.2 (along with the above mentioned bigger change).

	-ss

                 reply	other threads:[~2015-04-22  9:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150422095837.GC3624@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox