From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965970AbbDVJ6X (ORCPT ); Wed, 22 Apr 2015 05:58:23 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:34022 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965945AbbDVJ6W (ORCPT ); Wed, 22 Apr 2015 05:58:22 -0400 Date: Wed, 22 Apr 2015 18:58:37 +0900 From: Sergey Senozhatsky To: Linus Torvalds , Andrew Morton Cc: Minchan Kim , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: revert c72c6160d967ed26a0b136dbab337f821d233509 Message-ID: <20150422095837.GC3624@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, could you please revert c72c6160d967ed26a0b136dbab337f821d233509 ? Commit c72c6160d967 ("zram: move compact_store() to sysfs functions area") was intended to be a cosmetic change that w/o any functional change and was part of a bigger change: http://lkml.iu.edu/hypermail/linux/kernel/1503.1/01818.html (so c72c6160d967 removes compaction support). my bad, we managed to create a mess of patches for 4.1, so Andrew had to manually pick up and alter some commits. it didn't work well for that one. so we can either add missing compaction sysfs attr, or revert this change. Minchan Kim and I prefer to revert this commit http://lkml.iu.edu/hypermail/linux/kernel/1504.2/00623.html since it doesn't add any value to 4.1 per se. I will re-submit it for 4.2 (along with the above mentioned bigger change). -ss