Re: [PATCH] pl2303: Remove antiquated support for I330 phone

Greg Kroah-Hartman
2015-04-21T17:03:07Z

On Tue, Apr 21, 2015 at 05:07:05PM +0200, Jason A. Donenfeld wrote:
> Samsung has just released a portable USB3 SSD, coming in a very small
> and nice form factor. It's USB ID is 04e8:8001, which unfortunately is
> already used by the pl2303 USB serial driver for the Samsung I330 phone
> cradle. This phone was manufactured in 2001, and I seriously doubt it is
> still in use on any contemporary networks. Having pl2303 pick up this
> device ID results in conflicts with the usb-storage driver, which
> handles the newly released portable USB3 SSD. In this patch I remove the
> device ID of the old antiquated telephone from the pl2303 driver, so
> that usb-storage can handle it.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> drivers/usb/serial/pl2303.c | 1 -
> drivers/usb/serial/pl2303.h | 4 ----
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index 829604d..f5257af 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -61,7 +61,6 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
> { USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
> { USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
> - { USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },

How about adding a .driver_info quirk, that checks the device to see if
it matches a mass storage device? If so, don't accept the probe, which
will keep the driver from working on the SSD device, and still keep
working on the old docking station.

thanks,

greg k-h