From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Taeung Song <treeze.taeung@gmail.com>
Subject: Re: [PATCH v3] perf tools: Document --children option in more detail
Date: Wed, 22 Apr 2015 08:49:49 -0300 [thread overview]
Message-ID: <20150422114949.GA25482@kernel.org> (raw)
In-Reply-To: <20150422060906.GA21451@danjae.kornet>
Em Wed, Apr 22, 2015 at 03:09:06PM +0900, Namhyung Kim escreveu:
> On Tue, Apr 21, 2015 at 01:46:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > +--no-children option on the command line or by adding 'report.children
> > > > > += false' or 'top.children = false' in the perf config file.
> > > > One can as well use the OPTION_FOO shortening mechanism and instead use:
> > > > perf report --no-ch
> > > > Which is enough to disambiguate it from "--no-column-widths" and "--no-cpu".
> > > Are you saying that you want to add the short form instead of the full
> > > --no-chlidren name? I think we need to verbose in the manpage at
> > > least and it might not work in the future if some --chxxx option is
> > > added.
> > Perhaps:
> > "--no-children option on the command line or by adding 'report.children = false'
> > or 'top.children = false' in the perf config file.
> > A shorter form on the command line can be used, for instance '--no-ch'
> > is unambiguous at the time of this writing."
> I don't think it belongs here. The shorter form is not only for the
> --children, so it should be described in different place.
Well, I continue thinking it would add value, as the possibility of
shortening overly long options, like '--no-children' to reduce typing,
is handy, mentioning this possibility here and there, when such long
option names appears, would be of help.
But I won't insist, thanks for addressing the other suggestions,
applying.
- Arnaldo
prev parent reply other threads:[~2015-04-22 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 12:28 [PATCH v3] perf tools: Document --children option in more detail Namhyung Kim
2015-04-21 15:41 ` Arnaldo Carvalho de Melo
2015-04-21 16:16 ` Namhyung Kim
2015-04-21 16:46 ` Arnaldo Carvalho de Melo
2015-04-22 6:09 ` Namhyung Kim
2015-04-22 11:49 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422114949.GA25482@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox