From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933444AbbDVLt5 (ORCPT ); Wed, 22 Apr 2015 07:49:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:54639 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755977AbbDVLtz (ORCPT ); Wed, 22 Apr 2015 07:49:55 -0400 Date: Wed, 22 Apr 2015 08:49:49 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Taeung Song Subject: Re: [PATCH v3] perf tools: Document --children option in more detail Message-ID: <20150422114949.GA25482@kernel.org> References: <1429619311-27916-1-git-send-email-namhyung@kernel.org> <20150421154133.GF11111@kernel.org> <20150421161629.GG8483@danjae.kornet> <20150421164640.GG11111@kernel.org> <20150422060906.GA21451@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150422060906.GA21451@danjae.kornet> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Apr 22, 2015 at 03:09:06PM +0900, Namhyung Kim escreveu: > On Tue, Apr 21, 2015 at 01:46:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > +--no-children option on the command line or by adding 'report.children > > > > > += false' or 'top.children = false' in the perf config file. > > > > One can as well use the OPTION_FOO shortening mechanism and instead use: > > > > perf report --no-ch > > > > Which is enough to disambiguate it from "--no-column-widths" and "--no-cpu". > > > Are you saying that you want to add the short form instead of the full > > > --no-chlidren name? I think we need to verbose in the manpage at > > > least and it might not work in the future if some --chxxx option is > > > added. > > Perhaps: > > "--no-children option on the command line or by adding 'report.children = false' > > or 'top.children = false' in the perf config file. > > A shorter form on the command line can be used, for instance '--no-ch' > > is unambiguous at the time of this writing." > I don't think it belongs here. The shorter form is not only for the > --children, so it should be described in different place. Well, I continue thinking it would add value, as the possibility of shortening overly long options, like '--no-children' to reduce typing, is handy, mentioning this possibility here and there, when such long option names appears, would be of help. But I won't insist, thanks for addressing the other suggestions, applying. - Arnaldo