From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756282AbbDVMiO (ORCPT ); Wed, 22 Apr 2015 08:38:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43024 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbbDVMiI (ORCPT ); Wed, 22 Apr 2015 08:38:08 -0400 Date: Wed, 22 Apr 2015 14:38:00 +0200 From: Greg Kroah-Hartman To: Johan Hovold , Petr Slansky , Adam C Powell IV Cc: "Jason A. Donenfeld" , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pl2303, visor: Match I330 phone more precisely Message-ID: <20150422123800.GA27882@kroah.com> References: <20150421170301.GA17927@kroah.com> <1429697645-24505-1-git-send-email-Jason@zx2c4.com> <20150422112038.GA16828@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150422112038.GA16828@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2015 at 01:20:38PM +0200, Johan Hovold wrote: > On Wed, Apr 22, 2015 at 12:14:05PM +0200, Jason A. Donenfeld wrote: > > Samsung has just released a portable USB3 SSD, coming in a very small > > and nice form factor. It's USB ID is 04e8:8001, which unfortunately is > > already used by the pl2303 USB serial driver and the Palm Visor driver > > for the Samsung I330 phone cradle. Having pl2303 or visor pick up this > > device ID results in conflicts with the usb-storage driver, which > > handles the newly released portable USB3 SSD. > > First of all, the device should not be claimed by both pl2303 and visor. > This predates the git, but it looks like the device id should simply be > removed from pl2303. Care to do that as a preparatory patch? It was added back in 2004 in the 2.4.26 kernel release. Petr Slansky asked me to add it, and sent a patch as he had the device. But before that, back in 2003 Adam emailed saying that the visor driver worked with the device, and sent me a patch for it. I didn't notice the duplicate ids for well over a decade now :( I'd bet this is really a pl2303 device, given that the visor driver was just a "dumb" pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be removed. Petr, do you still have this device? Is it still really a pl2303 device? thanks, greg k-h