From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755991AbbDVNRB (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 09:17:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53208 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751055AbbDVNQ7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 09:16:59 -0400
Date: Wed, 22 Apr 2015 15:16:18 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave@sr71.net>, linux-kernel@vger.kernel.org, x86@kernel.org,
        tglx@linutronix.de, dave.hansen@linux.intel.com, riel@redhat.com,
        sbsiddha@gmail.com, luto@amacapital.net, mingo@redhat.com,
        hpa@zytor.com, fenghua.yu@intel.com
Subject: Re: [PATCH 01/16] x86, fpu: wrap get_xsave_addr() to make it safer
Message-ID: <20150422131618.GA16785@redhat.com>
References: <20150401004623.894DF37A@viggo.jf.intel.com> <20150401004624.49096AD0@viggo.jf.intel.com> <20150422104047.GA6897@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150422104047.GA6897@pd.tnic>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/22, Borislav Petkov wrote:
>
> On Tue, Mar 31, 2015 at 05:46:24PM -0700, Dave Hansen wrote:
> > + *
> > + * Inputs:
> > + *	@tsk: the task from which we are fetching xsave state
> > + *	@xsave_field: state which is defined in xsave.h (e.g. XSTATE_FP,
> > + *	XSTATE_SSE, etc...)
> > + * Output:
> > + *	address of the state in the xsave area.
> > + */
> > +void *tsk_get_xsave_field(struct task_struct *tsk, int xsave_field)
> > +{
> > +	union thread_xstate *xstate;
> > +
> > +	if (!used_math())
> > +		return NULL;
>
> Shouldn't this be
>
> 	if (!tsk_used_math(tsk))
>
> ?

I agree, tsk_used_math(tsk) looks better, simpy because we have this
argument.

But this "tsk" should be always current, otherwise this code is wrong
anyway. Say, unlazy_fpu(tsk) can't work if tsk != current.

So perhaps the comment should be updated...

> Because used_math() is looking at current, maybe even in
> preemption-enabled paths - I'm eyeing task_get_bounds_dir() - and
> that current might get changed from under us and it might happen that
> current != tsk. Yes, no?

Not sure I understand... "current" can't change from under us?

Even if this CPU switches to another thread which executes the same code,
that thread will obviously see another "current", but its "tsk" variable
will still match its "current".

Oleg.