From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757205AbbDVNZ6 (ORCPT ); Wed, 22 Apr 2015 09:25:58 -0400 Received: from mail.kernel.org ([198.145.29.136]:59776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756332AbbDVNZ4 (ORCPT ); Wed, 22 Apr 2015 09:25:56 -0400 Date: Wed, 22 Apr 2015 10:25:50 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim , Adrian Hunter Cc: Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , David Ahern Subject: Re: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2 Message-ID: <20150422132550.GA2316@kernel.org> References: <1429687101-4360-1-git-send-email-namhyung@kernel.org> <1429687101-4360-9-git-send-email-namhyung@kernel.org> <20150422105409.GA27697@krava.redhat.com> <20150422130325.GA1622@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150422130325.GA1622@danjae.kornet> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Apr 22, 2015 at 10:03:25PM +0900, Namhyung Kim escreveu: > Hi Jiri, > > On Wed, Apr 22, 2015 at 12:54:09PM +0200, Jiri Olsa wrote: > > On Wed, Apr 22, 2015 at 04:18:19PM +0900, Namhyung Kim wrote: > > > + if (asprintf(optstr, "Run scripts for samples of thread [%s]", > > > + thread__comm_str(thread)) < 0) > > > + return 0; > > > + } else if (sym) { > > .............. && sym->namelen ;-) > Ouch! sorry for missing this again. > Arnaldo, any chance you can fix this if you're gonna merge it? I can do that, but that slows down my rate of merging, so, if you could do like Adrian Hunter did, and fix this up, stick a V2 tag to it, then send it as a reply to the patch being fixed, that would help, so that when I get to it, and sort by thread, I will see the fix and will use it instead. It'll look like this: 633 N T 04/09 Adrian Hunter (4,4K) ├─>[PATCH 24/44] perf auxtrace: Add option to synthesize events for transactions -> 634 T 04/21 Adrian Hunter (8,9K) │ ┌─>[PATCH V2 23/44] perf tools: Add build option NO_AUXTRACE to exclude AUX area tracing 635 N T 04/09 Adrian Hunter (8,8K) ├─>[PATCH 23/44] perf tools: Add build option NO_AUXTRACE to exclude AUX area tracing 636 N T 04/09 Adrian Hunter (2,9K) ├─>[PATCH 22/44] perf tools: Hit all build ids when AUX area tracing 637 N T 04/09 Adrian Hunter ( 13K) ├─>[PATCH 21/44] perf tools: Add AUX area tracing index 638 N T 04/09 Adrian Hunter (6,1K) ├─>[PATCH 20/44] perf inject: Add Instruction Tracing support 639 N T 04/21 Adrian Hunter (3,2K) │ ┌─>[PATCH V2 19/44] perf inject: Re-pipe AUX area tracing events 640 N T 04/09 Adrian Hunter (3,2K) ├─>[PATCH 19/44] perf inject: Re-pipe AUX area tracing events 641 N T 04/09 Adrian Hunter (3,2K) ├─>[PATCH 18/44] perf report: Add Instruction Tracing support See the "V2" ones? That really helps, thanks Adrian! Additionaly, Adrian did, in the body of that message: ---- acme ---- acme --- acme --- acme --- Signed-off-by: Adrian Hunter --- Changes in V2: Get rid of MIN() tools/perf/Makefile.perf | 2 + tools/perf/builtin-inject.c | 53 +++++++++++------- ---- acme ---- acme --- acme --- acme --- Which is perfect, I know have the new version and the summary of what changed, in a way that git-am will trow away, etc. - Arnaldo > > > > but I think you're right, let's see if there's (sym && !sym->namelen) case, > > and fix it at the proper place.. not here > > Agreed. > > Thanks, > Namhyung