From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [RFC 0/6] perf tools: Report event parsing errors
Date: Wed, 22 Apr 2015 16:08:50 +0200 [thread overview]
Message-ID: <20150422140850.GC29174@krava.redhat.com> (raw)
In-Reply-To: <20150420203852.GO11111@kernel.org>
On Mon, Apr 20, 2015 at 05:38:52PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 20, 2015 at 10:15:39PM +0200, Jiri Olsa escreveu:
> > On Mon, Apr 20, 2015 at 05:09:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Sat, Apr 18, 2015 at 10:42:58PM +0200, Jiri Olsa escreveu:
> > > So, do you want me to apply this series and you work on top of it or
> > > should I wait for another that implements what Ingo suggested?
> >
> > I'll resend v2 with the update
> >
> > >
> > > Also, we have:
> > >
> > > [root@zoo ~]# perf stat --all -e cycles usleep 1
> > >
> > > Performance counter stats for 'system wide':
> > >
> > > 3,382,595 cycles
> > >
> > > 0.001739102 seconds time elapsed
> > >
> > > [root@zoo ~]# perf stat --all-cpus -e cycles usleep 1
> > >
> > > Performance counter stats for 'system wide':
> > >
> > > 2,435,672 cycles
> > >
> > > 0.001191689 seconds time elapsed
> > >
> > > [root@zoo ~]# perf stat --a -e cycles usleep 1
> > > Error: Ambiguous option: a (could be --no-no-aggr or --append)
> > >
> > > usage: perf stat [<options>] [<command>]
> > >
> > > [root@zoo ~]#
> > >
> > > Which is nice, wouldn't it be good to have it for the that as well, i.e.
> > > for your example "ev=" would be a valid, and shorter form of "even=" or
> > > "event=".
> >
> > hum, not sure I follow.. could you please explain in more details?
>
> This would be considered valid:
>
> $ ./perf record -e 'cpu/even=0x1/' ls
> event syntax error: 'cpu/even=0x1/'
> \___ unknown term
> valid terms: "event", "raw".
>
> "even=" would be recognized as a shorter form of "event=", "evint="
> would be invalid :-)
hum I see.. seem to be touching the bison/flex core part, might not
be that easy I'll think about it.. ;-)
thanks,
jirka
next prev parent reply other threads:[~2015-04-22 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 17:25 [RFC 0/6] perf tools: Report event parsing errors Jiri Olsa
2015-04-18 17:25 ` [PATCH 1/6] perf tools: Add parse_events_error interface Jiri Olsa
2015-04-18 17:25 ` [PATCH 2/6] perf tools: Add flex support for parse_events_error Jiri Olsa
2015-04-18 17:25 ` [PATCH 3/6] perf tools: Change parse_events_add_pmu interface Jiri Olsa
2015-04-18 17:25 ` [PATCH 4/6] perf tools: Add location to pmu event terms Jiri Olsa
2015-04-18 17:25 ` [PATCH 5/6] perf tools: Add term support for parse_events_error Jiri Olsa
2015-04-18 17:25 ` [PATCH 6/6] perf tools: Add tracepoint " Jiri Olsa
2015-04-18 17:39 ` [RFC 0/6] perf tools: Report event parsing errors Ingo Molnar
2015-04-18 20:42 ` Jiri Olsa
2015-04-20 20:09 ` Arnaldo Carvalho de Melo
2015-04-20 20:15 ` Jiri Olsa
2015-04-20 20:38 ` Arnaldo Carvalho de Melo
2015-04-22 14:08 ` Jiri Olsa [this message]
2015-04-22 14:37 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422140850.GC29174@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox