From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933419AbbDVOJO (ORCPT ); Wed, 22 Apr 2015 10:09:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42720 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932349AbbDVOJL (ORCPT ); Wed, 22 Apr 2015 10:09:11 -0400 Date: Wed, 22 Apr 2015 16:08:50 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Jiri Olsa , lkml , Peter Zijlstra , Paul Mackerras , David Ahern , Namhyung Kim Subject: Re: [RFC 0/6] perf tools: Report event parsing errors Message-ID: <20150422140850.GC29174@krava.redhat.com> References: <1429377946-2147-1-git-send-email-jolsa@kernel.org> <20150418173927.GA5897@gmail.com> <20150418204258.GA26943@krava.redhat.com> <20150420200936.GM11111@kernel.org> <20150420201539.GC10644@krava.redhat.com> <20150420203852.GO11111@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420203852.GO11111@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 05:38:52PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 20, 2015 at 10:15:39PM +0200, Jiri Olsa escreveu: > > On Mon, Apr 20, 2015 at 05:09:36PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Sat, Apr 18, 2015 at 10:42:58PM +0200, Jiri Olsa escreveu: > > > So, do you want me to apply this series and you work on top of it or > > > should I wait for another that implements what Ingo suggested? > > > > I'll resend v2 with the update > > > > > > > > Also, we have: > > > > > > [root@zoo ~]# perf stat --all -e cycles usleep 1 > > > > > > Performance counter stats for 'system wide': > > > > > > 3,382,595 cycles > > > > > > 0.001739102 seconds time elapsed > > > > > > [root@zoo ~]# perf stat --all-cpus -e cycles usleep 1 > > > > > > Performance counter stats for 'system wide': > > > > > > 2,435,672 cycles > > > > > > 0.001191689 seconds time elapsed > > > > > > [root@zoo ~]# perf stat --a -e cycles usleep 1 > > > Error: Ambiguous option: a (could be --no-no-aggr or --append) > > > > > > usage: perf stat [] [] > > > > > > [root@zoo ~]# > > > > > > Which is nice, wouldn't it be good to have it for the that as well, i.e. > > > for your example "ev=" would be a valid, and shorter form of "even=" or > > > "event=". > > > > hum, not sure I follow.. could you please explain in more details? > > This would be considered valid: > > $ ./perf record -e 'cpu/even=0x1/' ls > event syntax error: 'cpu/even=0x1/' > \___ unknown term > valid terms: "event", "raw". > > "even=" would be recognized as a shorter form of "event=", "evint=" > would be invalid :-) hum I see.. seem to be touching the bison/flex core part, might not be that easy I'll think about it.. ;-) thanks, jirka