From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934118AbbDVOaf (ORCPT ); Wed, 22 Apr 2015 10:30:35 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:35316 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933783AbbDVOaN (ORCPT ); Wed, 22 Apr 2015 10:30:13 -0400 Date: Wed, 22 Apr 2015 16:30:12 +0200 From: Johan Hovold To: "Jason A. Donenfeld" Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Greg Kroah-Hartman , Sergei Shtylyov Subject: Re: [PATCH 2/2] visor: Match I330 phone more precisely Message-ID: <20150422143012.GC16828@localhost> References: <20150422112038.GA16828@localhost> <1429706109-28400-1-git-send-email-Jason@zx2c4.com> <1429706109-28400-2-git-send-email-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429706109-28400-2-git-send-email-Jason@zx2c4.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2015 at 02:35:09PM +0200, Jason A. Donenfeld wrote: > Samsung has just released a portable USB3 SSD, coming in a very small > and nice form factor. It's USB ID is 04e8:8001, which unfortunately is > already used by the Palm Visor driver for the Samsung I330 phone cradle. > Having pl2303 or visor pick up this device ID results in conflicts with > the usb-storage driver, which handles the newly released portable USB3 > SSD. > > To work around this conflict, I've dug up a mailing list post [1] from a > long time ago, in which a user posts the full USB descriptor > information. The most specific value in this appears to be the interface > class, which has value 255 (0xff). Since usb-storage requires an > interface class of 0x8, I believe it's correct to disambiguate the two > devices by matching on 0xff inside visor. > > [1] http://permalink.gmane.org/gmane.linux.usb.user/4264 > > Signed-off-by: Jason A. Donenfeld Both patches look good, but next time remember to include a patch revision in the subject of all patches in a series (this would be [PATCH v3]). Please use a "USB: " prefix as well. I'll fix it up before applying this time. Thanks, Johan