From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbbDWEX3 (ORCPT ); Thu, 23 Apr 2015 00:23:29 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34175 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbbDWEX2 (ORCPT ); Thu, 23 Apr 2015 00:23:28 -0400 Date: Thu, 23 Apr 2015 13:23:43 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCHv2 07/10] zram: report every added and removed device Message-ID: <20150423042343.GB724@swordfish> References: <1429185356-11096-1-git-send-email-sergey.senozhatsky@gmail.com> <1429185356-11096-8-git-send-email-sergey.senozhatsky@gmail.com> <20150423023859.GF24928@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150423023859.GF24928@blaptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/23/15 11:38), Minchan Kim wrote: > > + > > + pr_info("Removed device: %s\n", zram->disk->disk_name); > > trivial: > > why did you add the info in the middle of logic functions? > Without special reason, let's add it top of the zram_remove. > ok. -ss > Acked-by: Minchan Kim > > > del_gendisk(zram->disk); > > put_disk(zram->disk); > > kfree(zram); > > @@ -1281,7 +1285,6 @@ static void destroy_devices(void) > > idr_for_each(&zram_index_idr, &zram_exit_cb, NULL); > > idr_destroy(&zram_index_idr); > > unregister_blkdev(zram_major, "zram"); > > - pr_info("Destroyed device(s)\n"); > > } > > > > static int __init zram_init(void) > > @@ -1300,7 +1303,6 @@ static int __init zram_init(void) > > goto out_error; > > } > > > > - pr_info("Created %u device(s)\n", num_devices); > > return 0; > > > > out_error: > > -- > > 2.4.0.rc2 > > > > -- > Kind regards, > Minchan Kim >