From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"florian.c.schilhabel@googlemail.com"
<florian.c.schilhabel@googlemail.com>,
"thomas@grouk.net" <thomas@grouk.net>,
"Babu, Viswanathan (V.)" <vbabu3@visteon.com>,
"vthakkar1994@gmail.com" <vthakkar1994@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Staging: rtl8712: Removed unused return variable
Date: Thu, 23 Apr 2015 18:57:13 +0300 [thread overview]
Message-ID: <20150423155713.GK14154@mwanda> (raw)
In-Reply-To: <55390FD3.9050505@lwfinger.net>
This patch is a coccinelle thing, the reasoning behind it is that
literals are more clear than variables.
return status; <-- Ambiguous. This could be returning anything,
you have to look at the context.
return 0; <-- Clear.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-23 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 15:00 [PATCH v2] Staging: rtl8712: Removed unused return variable DHANAPAL, GNANACHANDRAN (G.)
2015-04-23 15:29 ` Larry Finger
2015-04-23 15:57 ` Dan Carpenter [this message]
2015-04-24 5:57 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423155713.GK14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gdhanapa@visteon.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@grouk.net \
--cc=vbabu3@visteon.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox