From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: fbtft: Disable DMA support if DMA is not available
Date: Thu, 23 Apr 2015 21:17:38 +0200 [thread overview]
Message-ID: <20150423191738.GA14247@kroah.com> (raw)
In-Reply-To: <1429814835-22957-1-git-send-email-geert@linux-m68k.org>
On Thu, Apr 23, 2015 at 08:47:15PM +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `fbtft_framebuffer_alloc':
> (.text+0xb53cae): undefined reference to `dmam_alloc_coherent'
>
> As DMA support is already optional, make it depend on HAS_DMA.
>
> If !HAS_DMA, "dma" will always be false, and the compiler will optimize
> away the call to dmam_alloc_coherent().
Oh that's "sneaky" and not good, let's just make this driver be
dependant on DMA and be done with it. I don't like to rely on the
optimizer to get things to work properly.
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-23 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 18:47 [PATCH v2] staging: fbtft: Disable DMA support if DMA is not available Geert Uytterhoeven
2015-04-23 19:17 ` Greg Kroah-Hartman [this message]
2015-04-24 7:15 ` Geert Uytterhoeven
2015-04-24 7:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423191738.GA14247@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox