From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbbDZFEi (ORCPT ); Sun, 26 Apr 2015 01:04:38 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34156 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbbDZFEg (ORCPT ); Sun, 26 Apr 2015 01:04:36 -0400 Date: Sun, 26 Apr 2015 10:34:24 +0530 From: Sudip Mukherjee To: One Thousand Gnomes Cc: Greg KH , Dan Carpenter , jdelvare@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 WIP 3/3] i2c-parport: modify driver to use new parport device model Message-ID: <20150426050424.GA5943@sudip-PC> References: <1429967240-4033-1-git-send-email-sudipm.mukherjee@gmail.com> <1429967240-4033-3-git-send-email-sudipm.mukherjee@gmail.com> <20150425233247.3fe61f57@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150425233247.3fe61f57@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 25, 2015 at 11:32:47PM +0100, One Thousand Gnomes wrote: > > +static int parport; > > +module_param(parport, int, 0); > > +MODULE_PARM_DESC(parport, "The parport to be used, default parport0\n"); > > Minor suggested enhancement: this ought to be an array so you can attach > multiple instances to a system. ok. infact, i was looking at paride yesterday night, and it is also having option to register maximum of 4 instances. the current patchset allows registration of device to only one port. I need to change that part. regards sudip > > Alan