Re: [PATCH 1/3] ARM: dts: sunxi: A10s Olinuxino add missing SPI and simplefb.

Michal Suchanek
2015-04-26T09:22:18Z

Hello,

On 26 April 2015 at 10:39, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Mon, Mar 23, 2015 at 03:00:31PM +0100, Michal Suchanek wrote:
>> Signed-off-by: Michal Suchanek <hramrach@gmail.com>

>> &ohci0 {
>> status = "okay";
>> };
>> diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun5i-a10s.dtsi
>> index a78c95d..438eba1 100644
>> --- a/arch/arm/boot/dts/sun5i-a10s.dtsi
>> +++ b/arch/arm/boot/dts/sun5i-a10s.dtsi
>> @@ -154,6 +154,20 @@
>> clocks = <&apb1_gates 18>;
>> status = "disabled";
>> };
>> +
>> + spi2: spi@01c17000 {
>> + compatible = "allwinner,sun4i-a10-spi";
>> + reg = <0x01c17000 0x1000>;
>> + interrupts = <12>;
>> + clocks = <&ahb_gates 22>, <&spi2_clk>;
>> + clock-names = "ahb", "mod";
>> + dmas = <&dma SUN4I_DMA_DEDICATED 29>,
>> + <&dma SUN4I_DMA_DEDICATED 28>;
>> + dma-names = "rx", "tx";
>> + status = "disabled";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>> };
>> };
>
> This should be in sun5i.dtsi (and in a separate patch).
>
>> @@ -198,4 +212,18 @@
>> allwinner,drive = <SUN4I_PINCTRL_30_MA>;
>> allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> };
>> +
>> + spi2_pins_a: spi2@0 {
>> + allwinner,pins = "PB11", "PB12", "PB13", "PB14";
>> + allwinner,function = "spi2";
>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> + };
>> +
>> + spi2_pins_b: spi2@1 {
>> + allwinner,pins = "PE00", "PE01", "PE02", "PE03";
>> + allwinner,function = "spi2";
>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> + };
>> };
>
> Ditto.
>

A13 does not have these pins so maybe not?

Thanks

Michal