From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Kevin Hilman <khilman@linaro.org>,
Mike Galbraith <bitbucket@online.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 3/3 V8] workqueue: Allow modifying low level unbound workqueue cpumask
Date: Mon, 27 Apr 2015 23:49:18 -0400 [thread overview]
Message-ID: <20150428034918.GD2152@htj.duckdns.org> (raw)
In-Reply-To: <553EEF5F.1090703@cn.fujitsu.com>
Hello,
On Tue, Apr 28, 2015 at 10:24:31AM +0800, Lai Jiangshan wrote:
> >> Wouldn't this make a lot more sense above when copying @attrs into
> >> @new_attrs? The comment there even says "make a copy of @attrs and
> >> sanitize it". Copy to @new_attrs, mask with wq_unbound_cpumask and
> >> fall back to wq_unbound_cpumask if empty.
>
> We need to save the user original configured attrs.
> When any time wq_unbound_cpumask is changed, we should use
> the user original configured attrs (cpumask) to re-calculate
> the pwqs and avoid losing any information.
Sure, we can do that for new_attrs and then mask tmp_attrs further w/
wq_unbound_cpumask, no?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-04-28 3:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 9:58 [PATCH 0/3 V8] workqueue: Introduce low-level unbound wq sysfs cpumask Lai Jiangshan
2015-04-27 9:58 ` [PATCH 1/3 V8] workqueue: split apply_workqueue_attrs() into 3 stages Lai Jiangshan
2015-04-27 9:58 ` [PATCH 2/3 V8] workqueue: Create low-level unbound workqueues cpumask Lai Jiangshan
2015-04-27 15:45 ` Tejun Heo
2015-04-27 9:58 ` [PATCH 3/3 V8] workqueue: Allow modifying low level unbound workqueue cpumask Lai Jiangshan
2015-04-27 16:07 ` Tejun Heo
2015-04-28 1:44 ` Lai Jiangshan
2015-04-28 2:24 ` Lai Jiangshan
2015-04-28 3:49 ` Tejun Heo [this message]
2015-04-28 10:16 ` Lai Jiangshan
2015-04-30 9:23 ` Lai Jiangshan
2015-04-28 3:44 ` Tejun Heo
2015-04-28 4:36 ` Mike Galbraith
2015-04-28 10:31 ` Lai Jiangshan
2015-04-28 12:15 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428034918.GD2152@htj.duckdns.org \
--to=tj@kernel.org \
--cc=bitbucket@online.de \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=khilman@linaro.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox