From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965784AbbD1Mhm (ORCPT ); Tue, 28 Apr 2015 08:37:42 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:34137 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965617AbbD1Mhl (ORCPT ); Tue, 28 Apr 2015 08:37:41 -0400 Date: Tue, 28 Apr 2015 14:37:25 +0200 From: Sascha Hauer To: Chaotian Jing Cc: Rob Herring , Matthias Brugger , Chris Ball , Ulf Hansson , Mark Rutland , James Liao , srv_heupstream@mediatek.com, Arnd Bergmann , devicetree@vger.kernel.org, Hongzhou Yang , Catalin Marinas , bin.zhang@mediatek.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, Sascha Hauer , "Joe.C" , Eddie Huang , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 6/7] ARM: mediatek: dts: Add emmc support to mt8135 Message-ID: <20150428123725.GK6325@pengutronix.de> References: <1430214525-19198-1-git-send-email-chaotian.jing@mediatek.com> <1430214525-19198-7-git-send-email-chaotian.jing@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430214525-19198-7-git-send-email-chaotian.jing@mediatek.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:35:10 up 43 days, 27 min, 94 users, load average: 0.20, 0.11, 0.12 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2015 at 05:48:44PM +0800, Chaotian Jing wrote: > From: Yingjoe Chen > > Add emmc node for mt8135.dtsi & mt8135-evbp1.dts > > Signed-off-by: Yingjoe Chen > Signed-off-by: Chaotian Jing > --- > arch/arm/boot/dts/mt8135-evbp1.dts | 141 +++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/mt8135.dtsi | 26 +++++++ > 2 files changed, 167 insertions(+) > > diff --git a/arch/arm/boot/dts/mt8135-evbp1.dts b/arch/arm/boot/dts/mt8135-evbp1.dts > index 357a91f..6d2fee9 100644 > --- a/arch/arm/boot/dts/mt8135-evbp1.dts > +++ b/arch/arm/boot/dts/mt8135-evbp1.dts > @@ -24,6 +24,147 @@ > }; > }; > > +&mmc0 { > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc0_pins_default>; > + pinctrl-1 = <&mmc0_pins_uhs>; > + status = "okay"; > + bus-width = <8>; > + max-frequency = <50000000>; > + cap-mmc-highspeed; > + vmmc-supply = <&mt6397_vemc_3v3_reg>; > + non-removable; > + func = "EMMC"; ... > + func = "SDCARD"; These have been removed in earlier versions, right? > diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi > index 4d1ddd9..2c5c4da 100644 > --- a/arch/arm/boot/dts/mt8135.dtsi > +++ b/arch/arm/boot/dts/mt8135.dtsi > @@ -212,5 +212,31 @@ > status = "disabled"; > }; > > + mmc0: mmc@11230000 { > + compatible = "mediatek,mt8135-mmc"; > + reg = <0 0x11230000 0 0x108>; Please use the whole register space for the controller here, not only the one actually used by the registers. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |