From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965799AbbD1My7 (ORCPT ); Tue, 28 Apr 2015 08:54:59 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36425 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965549AbbD1My4 (ORCPT ); Tue, 28 Apr 2015 08:54:56 -0400 Date: Tue, 28 Apr 2015 05:54:56 -0700 From: Christoph Hellwig To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development Message-ID: <20150428125456.GC30852@infradead.org> References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com> <20150418013541.25237.36797.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150418013541.25237.36797.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eww, the --wrap stuff is too ugly too live. Just implement the implemenetation of persistent nvdimms into qemu where it belongs. Note that having a not actually persistent implementation that register with the subsystems which doesn't need these hacks still sounds ok to me, altough I suspect most users would much prefer the virtualization based variant.