From: Alasdair G Kergon <agk@redhat.com>
To: Ming Lin <mlin@kernel.org>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>,
Kent Overstreet <kent.overstreet@gmail.com>,
Dongsu Park <dongsu.park@profitbricks.com>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
drbd-user@lists.linbit.com, Jiri Kosina <jkosina@suse.cz>,
Yehuda Sadeh <yehuda@inktank.com>, Sage Weil <sage@inktank.com>,
Alex Elder <elder@kernel.org>,
ceph-devel@vger.kernel.org, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Neil Brown <neilb@suse.de>,
linux-raid@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH 07/10] block: kill merge_bvec_fn() completely
Date: Tue, 28 Apr 2015 18:31:37 +0100 [thread overview]
Message-ID: <20150428173137.GC12975@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <1430203717-13307-8-git-send-email-mlin@kernel.org>
On Mon, Apr 27, 2015 at 11:48:34PM -0700, Ming Lin wrote:
> As generic_make_request() is now able to handle arbitrarily sized bios,
> it's no longer necessary for each individual block driver to define its
> own ->merge_bvec_fn() callback. Remove every invocation completely.
merge_bvec_fn is also about telling the code building up bios what optimum
maximum size to use.
Have you got some test data to demonstrate that we won't find some situations
where performance is now lost by code building up bios that are far too big
and are always going to have to be split up later?
Alasdair
next prev parent reply other threads:[~2015-04-28 17:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 6:48 [RFC PATCH v2 00/10] simplify block layer based on immutable biovecs Ming Lin
2015-04-28 6:48 ` [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-04-28 11:43 ` Christoph Hellwig
2015-04-28 16:01 ` Keith Busch
2015-05-06 6:08 ` Ming Lin
2015-05-06 6:48 ` Christoph Hellwig
2015-05-06 7:13 ` Ming Lin
2015-04-28 6:48 ` [PATCH 02/10] block: simplify bio_add_page() Ming Lin
2015-04-28 12:12 ` Christoph Hellwig
2015-04-29 5:42 ` Ming Lin
2015-04-28 6:48 ` [PATCH 03/10] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Ming Lin
2015-04-28 6:48 ` [PATCH 04/10] bcache: clean up hacks around bio_split_pool Ming Lin
2015-04-28 12:14 ` Christoph Hellwig
2015-04-29 5:43 ` Ming Lin
2015-04-28 6:48 ` [PATCH 05/10] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-04-28 6:48 ` [PATCH 06/10] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-04-28 6:48 ` [PATCH 07/10] block: kill merge_bvec_fn() completely Ming Lin
2015-04-28 17:31 ` Alasdair G Kergon [this message]
2015-04-29 6:32 ` Ming Lin
2015-04-28 22:09 ` NeilBrown
2015-05-04 7:47 ` Ming Lin
2015-05-06 7:10 ` Ming Lin
2015-05-06 7:26 ` Christoph Hellwig
2015-05-06 17:05 ` Ming Lin
2015-04-28 6:48 ` [PATCH 08/10] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-04-28 6:48 ` [PATCH 09/10] md/raid10: make sync_request_write() call bio_copy_data() Ming Lin
2015-04-28 6:48 ` [PATCH 10/10] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428173137.GC12975@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=dchinner@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dongsu.park@profitbricks.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=elder@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jkosina@suse.cz \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mlin@kernel.org \
--cc=neilb@suse.de \
--cc=sage@inktank.com \
--cc=snitzer@redhat.com \
--cc=yehuda@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).