From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422823AbbD2KzK (ORCPT ); Wed, 29 Apr 2015 06:55:10 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:34290 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422718AbbD2KzH (ORCPT ); Wed, 29 Apr 2015 06:55:07 -0400 Date: Wed, 29 Apr 2015 11:55:02 +0100 From: Lee Jones To: Charles Keepax Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] mfd: arizona: Remove redundant register sync Message-ID: <20150429105502.GY9169@x1> References: <1429709688-24047-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1429709688-24047-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Apr 2015, Charles Keepax wrote: > This soft reset used to be located after the register patch had been > applied, but has since moved to before the patch is applied. At the new > location there is no requirement to do a register sync as no register > writes will have happened yet. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 6ca6dfa..aed43a5 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona) > > /* If we have a /RESET GPIO we'll already be reset */ > if (!arizona->pdata.reset) { > - regcache_mark_dirty(arizona->regmap); > - > ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0); > if (ret != 0) { > dev_err(dev, "Failed to reset device: %d\n", ret); > @@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona) > } > > msleep(1); > - > - ret = regcache_sync(arizona->regmap); > - if (ret != 0) { > - dev_err(dev, "Failed to sync device: %d\n", ret); > - goto err_reset; > - } > } > > /* Ensure device startup is complete */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog