Re: [PATCH v2 9/9] mfd: wm5110: Add delay before releasing reset line

[Lee Jones <lee.jones@linaro.org>]

On Fri, 17 Apr 2015, Charles Keepax wrote:

> On the wm5110 it is important the reset line is held for slightly longer
> to ensure the device starts up well. This patch adds a 5mS delay for
> this.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index def3ad3..e1f0a68 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -259,6 +259,15 @@ static inline void arizona_enable_reset(struct arizona *arizona)
>  static void arizona_disable_reset(struct arizona *arizona)
>  {
>  	if (arizona->pdata.reset) {
> +		switch (arizona->type) {
> +		case WM5110:
> +		case WM8280:

Comment here please.

> +			msleep(5);
> +			break;
> +		default:
> +			break;
> +		}
> +
>  		gpio_set_value_cansleep(arizona->pdata.reset, 1);
>  		msleep(1);
>  	}

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog