From: mancha security <mancha1@zoho.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
"H. Peter Anvin" <hpa@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro
Date: Wed, 29 Apr 2015 14:59:56 +0000 [thread overview]
Message-ID: <20150429145956.GB12861@zoho.com> (raw)
In-Reply-To: <CAJhHMCBqbfXQ6P-eiLtM7AzxyMtM_5jvHCo-87UGDPz7xV6FHA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
On Wed, Apr 29, 2015 at 10:51:40AM -0400, Pranith Kumar wrote:
> Hi Daniel,
>
> On Wed, Apr 29, 2015 at 10:42 AM, Daniel Borkmann <daniel@iogearbox.net> wrote:
> > Cleanup commit 23ebdedc67e ("compiler-intel.h: Remove duplicate
> > definition") removed the double definition of __memory_barrier()
> > intrinsics.
> >
> > However, in doing so, it also removed the preceding #undef barrier,
> > meaning, the actual barrier() macro from compiler-gcc.h with inline
> > asm is still in place when __GNUC__ is provided.
>
> When you use the Intel compilers, the barrier() definition will come
> from compiler.h and not compiler-gcc.h. That is what the commit
> message says in 73679e508201(your commit message has the wrong hash).
> I don't understand what problem you are seeing with this, can you
> please explain?
>
> Thanks!
Hi Pranith.
The problem is that ICC defines __GNUC__ so barrier() gets defined
in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h
so compiler.h will never define barrier to __memory_barrier().
--mancha
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-29 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 14:42 [PATCH] compiler-intel: fix wrong compiler barrier() macro Daniel Borkmann
2015-04-29 14:51 ` Pranith Kumar
2015-04-29 14:59 ` mancha security [this message]
2015-04-29 16:40 ` Pranith Kumar
2015-04-29 16:59 ` Daniel Borkmann
2015-04-29 17:17 ` Pranith Kumar
2015-04-30 5:58 ` mancha security
2015-04-29 15:04 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429145956.GB12861@zoho.com \
--to=mancha1@zoho.com \
--cc=bobby.prani@gmail.com \
--cc=daniel@iogearbox.net \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox