Re: [PATCH V3 07/25] perf auxtrace: Add option to synthesize events for transactions

Jiri Olsa
2015-04-28T13:02:09Z

On Fri, Apr 24, 2015 at 10:29:49PM +0300, Adrian Hunter wrote:
> Add AUX area tracing option 'x' to synthesize events for
> transactions. This will be used by Intel PT to synthesize
> an event record for each TSX start, commit or abort.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/Documentation/perf-inject.txt | 9 +++++----
> tools/perf/Documentation/perf-report.txt | 9 +++++----
> tools/perf/Documentation/perf-script.txt | 9 +++++----
> tools/perf/util/auxtrace.c | 5 ++++-
> tools/perf/util/auxtrace.h | 2 ++
> 5 files changed, 21 insertions(+), 13 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-inject.txt b/tools/perf/Documentation/perf-inject.txt
> index bb1f655..b876ae3 100644
> --- a/tools/perf/Documentation/perf-inject.txt
> +++ b/tools/perf/Documentation/perf-inject.txt
> @@ -52,11 +52,12 @@ OPTIONS
> b synthesize branches events
> c synthesize branches events (calls only)
> r synthesize branches events (returns only)
> + x synthesize transactions events
> e synthesize error events
> d create a debug log
> - g synthesize a call chain for instructions events
> + g synthesize a call chain (use with i or x)
>
> - The default is all events i.e. the same as --itrace=ibe
> + The default is all events i.e. the same as --itrace=ibxe
>
> In addition, the period (default 100000) for instructions events
> can be specified in units of:
> @@ -67,8 +68,8 @@ OPTIONS
> us microseconds
> ns nanoseconds (default)
>
> - Also the call chain size (default 16, max. 1024) for instructions
> - events can be specified.
> + Also the call chain size (default 16, max. 1024) for instructions or
> + transactions events can be specified.

Do you want to carry on with updating 3 places of the same doc?
I wonder it'd be better to have perf-auxtrace.txt for auxtrace details.

jirka