From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6
Date: Wed, 29 Apr 2015 13:27:40 -0300 [thread overview]
Message-ID: <20150429162740.GL2079@redhat.com> (raw)
In-Reply-To: <1430322871-18107-1-git-send-email-namhyung@kernel.org>
> The YYLTYPE_IS_TRIVIAL is defined in the Build file, but unlike
> pmu-bison.c, gcc complained about it for parse-events-bison.c:
>
> CC util/parse-events-bison.o
> In file included from util/parse-events.y:16:
> util/parse-events-bison.h:101:1: error: "YYLTYPE_IS_TRIVIAL" redefined
> <command-line>: error: this is the location of the previous definition
> make[3]: *** [util/parse-events-bison.o] Error 1
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Ok, so this helps, it builds now on RHEL6.6, which was something I and
Jiri were chasing, but why has it complained for one and not the other?
Ideas?
- Arnaldo
> ---
> tools/perf/util/Build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index b6c3f39f081a..28af8e2825b3 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -118,7 +118,7 @@ $(OUTPUT)util/pmu-bison.c: util/pmu.y
>
> CFLAGS_parse-events-flex.o += -w
> CFLAGS_pmu-flex.o += -w
> -CFLAGS_parse-events-bison.o += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
> +CFLAGS_parse-events-bison.o += -DYYENABLE_NLS=0 -w
> CFLAGS_pmu-bison.o += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
>
> $(OUTPUT)util/parse-events.o: $(OUTPUT)util/parse-events-flex.c
> $(OUTPUT)util/parse-events-bison.c
> --
> 2.3.5
next prev parent reply other threads:[~2015-04-29 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 15:54 [PATCH] perf tools: Fix bison-related build failure on CentOS 6 Namhyung Kim
2015-04-29 16:02 ` Jiri Olsa
2015-04-29 16:11 ` Namhyung Kim
2015-04-29 16:47 ` Arnaldo Carvalho de Melo
2015-04-29 16:27 ` Arnaldo Carvalho de Melo [this message]
2015-04-29 17:57 ` Jiri Olsa
2015-04-29 18:14 ` Jiri Olsa
2015-04-29 18:47 ` Arnaldo Carvalho de Melo
2015-04-29 19:14 ` Jiri Olsa
2015-05-06 3:12 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429162740.GL2079@redhat.com \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox