From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbbEDUzH (ORCPT ); Mon, 4 May 2015 16:55:07 -0400 Received: from mail.kernel.org ([198.145.29.136]:36116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbbEDUy7 (ORCPT ); Mon, 4 May 2015 16:54:59 -0400 Date: Wed, 29 Apr 2015 18:36:58 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen Subject: Re: [PATCH] perf report: Fix -T/--threads option to work again Message-ID: <20150429213658.GA29633@kernel.org> References: <1430309328-28317-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430309328-28317-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Apr 29, 2015 at 09:08:48PM +0900, Namhyung Kim escreveu: > The commit 512ae1bd6acb ("perf tools: Consolidate management of default > sort orders") changed default value of the 'sort_order' variable to NULL > indicating that users don't set any sort keys on the command line. > > However it missed to update a check in perf_evlist__tty_browse_hists() > so that 'perf report -T' cannot show the per-thread values after the > normal output. This patch fixes it to work again. > > Note that the -T option only works on --stdio and neither --sort nor > --parent option was given. Thanks, applied to perf/urgent. - Arnaldo