From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751085AbbD3FrN (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 Apr 2015 01:47:13 -0400
Received: from mail-pd0-f173.google.com ([209.85.192.173]:34874 "EHLO
	mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750705AbbD3FrM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 Apr 2015 01:47:12 -0400
Date: Thu, 30 Apr 2015 14:47:02 +0900
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Nitin Gupta <ngupta@vflare.org>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCHv3 9/9] zram: add dynamic device add/remove functionality
Message-ID: <20150430054702.GA21771@blaptop>
References: <1430140911-7818-1-git-send-email-sergey.senozhatsky@gmail.com>
 <1430140911-7818-10-git-send-email-sergey.senozhatsky@gmail.com>
 <20150429001624.GA3917@swordfish>
 <20150429064858.GA5125@blaptop>
 <20150429070218.GA616@swordfish>
 <20150429072328.GA2987@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150429072328.GA2987@swordfish>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Sergey,

On Wed, Apr 29, 2015 at 04:23:28PM +0900, Sergey Senozhatsky wrote:
> On (04/29/15 16:02), Sergey Senozhatsky wrote:
> > sure. I was talking about this one:
> > 
> > 	CPU0			CPU1
> > 	umount
> > 	zram_remove()
> > 	lock ->bd_mutex
> > 	zram_reset_device()
> > 	unlock ->bd_mutex
> > 				disksize_store
> > 				mount
> > 				echo 'test' > /mnt/test
> > 	kfree zram
> > 				zram write
> > 
> 
> I'll take a look later today. currently I think of something like:
> 
> 
> 	sysfs_remove_group()
> 	lock ->bd_mutex
> 		... check ->bd_openers
> 
> 	zram_reset_device()
> 	blk_cleanup_queue()
> 	del_gendisk()
> 	put_disk()
> 
> 	unlock ->bd_mutex
> 	bdput bdev
> 
> 	idr_remove()
> 	kfree(zram)
> 
> 
> iow, idr_remove() and kfree() are done outside of ->bd_mutex lock.
> but I may be wrong. haven't tested yet. but seems reasonable: we
> invalidate ->bdev, delete partitions, etc., holding ->bd_mutex and
> then release ->bdev, which does final put. need to check that in
> detail.
> 
> 	-ss


Isn't it related to bd_mutex?
I think the problem of deadlock is that you are trying to remove sysfs file
in sysfs handler.

#> echo 1 > /sys/xxx/zram_remove

kernfs_fop_write - hold s_active
  -> zram_remove_store
    -> zram_remove
      -> sysfs_remove_group - hold s_active *again*

Right?

-- 
Kind regards,
Minchan Kim