From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751030AbbD3Jan (ORCPT ); Thu, 30 Apr 2015 05:30:43 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38821 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbbD3Jak (ORCPT ); Thu, 30 Apr 2015 05:30:40 -0400 Date: Thu, 30 Apr 2015 10:30:29 +0100 From: Lee Jones To: Chanwoo Choi Cc: Ramakrishna Pallala , linux-kernel@vger.kernel.org, Samuel Ortiz , Jacob Pan Subject: Re: [PATCH v9] extcon-axp288: Add axp288 extcon driver support Message-ID: <20150430093029.GA1815@x1> References: <1430406885-17973-1-git-send-email-ramakrishna.pallala@intel.com> <5541DC33.80400@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5541DC33.80400@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Apr 2015, Chanwoo Choi wrote: > Hi Ram, > > This patch has still one minor issue on below comment. > But I fix it and will apply it on extcon-next branch > after discussing how to apply this patch with Lee Jones (MFD maintainer). > > Dear Lee, > Do you want to send pull request after I make the immutable branch > for this patch? or apply this patch on extcon git without any pull request? Let's try without the pull-request. > On 05/01/2015 12:14 AM, Ramakrishna Pallala wrote: > > This patch adds the extcon support for AXP288 PMIC which > > has the BC1.2 charger detection capability. Additionally > > it also adds the USB mux switching support b/w SOC and PMIC > > based on GPIO control. > > > > Signed-off-by: Ramakrishna Pallala > > Acked-by: Lee Jones > > --- > > drivers/extcon/Kconfig | 7 + > > drivers/extcon/Makefile | 1 + > > drivers/extcon/extcon-axp288.c | 385 ++++++++++++++++++++++++++++++++++++++++ > > include/linux/mfd/axp20x.h | 5 + > > 4 files changed, 398 insertions(+) > > create mode 100644 drivers/extcon/extcon-axp288.c > > > > [snip] > > > + vbus_attach ? EXTCON_GPIO_MUX_SEL_SOC > > + : EXTCON_GPIO_MUX_SEL_PMIC); > > + > > + atomic_notifier_call_chain(&info->otg->notifier, > > + vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); > > + } > > + > > + if (notify_charger) > > + extcon_set_cable_state(info->edev, cable, vbus_attach); > > + > > + /* Clear the flags on disconnect event */ > > + if (!vbus_attach) > > + notify_otg = notify_charger = false; > > + > > + return 0; > > + > > +dev_det_ret: > > + if (ret < 0) > > + dev_err(info->dev, "BC Mod detection error\n"); > > You miss the fix about following comment. > "BC Mod detection error\n" -> "failed to detect BC Mod\n" > > [snip] > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog