* [PATCH] i2o: fix semicolon.cocci warnings [not found] <201504302132.UufsL5Kz%fengguang.wu@intel.com> @ 2015-04-30 13:03 ` kbuild test robot 2015-04-30 14:12 ` Greg Kroah-Hartman 2015-04-30 13:03 ` [PATCH] i2o: fix simple_return.cocci warnings kbuild test robot 1 sibling, 1 reply; 3+ messages in thread From: kbuild test robot @ 2015-04-30 13:03 UTC (permalink / raw) To: Alan Cox; +Cc: kbuild-all, Greg Kroah-Hartman, devel, linux-kernel drivers/staging/i2o/iop.c:1065:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Alan Cox <alan@linux.intel.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- iop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/i2o/iop.c +++ b/drivers/staging/i2o/iop.c @@ -1062,7 +1062,7 @@ struct i2o_controller *i2o_iop_alloc(voi I2O_MSG_INPOOL_MIN)) { kfree(c); return ERR_PTR(-ENOMEM); - }; + } INIT_LIST_HEAD(&c->devices); spin_lock_init(&c->lock); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2o: fix semicolon.cocci warnings 2015-04-30 13:03 ` [PATCH] i2o: fix semicolon.cocci warnings kbuild test robot @ 2015-04-30 14:12 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2015-04-30 14:12 UTC (permalink / raw) To: kbuild test robot; +Cc: Alan Cox, kbuild-all, devel, linux-kernel On Thu, Apr 30, 2015 at 09:03:03PM +0800, kbuild test robot wrote: > drivers/staging/i2o/iop.c:1065:2-3: Unneeded semicolon > > > Removes unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Alan Cox <alan@linux.intel.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- Someone else sent this before you, it was in my queue of patches to apply, sorry. greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] i2o: fix simple_return.cocci warnings [not found] <201504302132.UufsL5Kz%fengguang.wu@intel.com> 2015-04-30 13:03 ` [PATCH] i2o: fix semicolon.cocci warnings kbuild test robot @ 2015-04-30 13:03 ` kbuild test robot 1 sibling, 0 replies; 3+ messages in thread From: kbuild test robot @ 2015-04-30 13:03 UTC (permalink / raw) To: Alan Cox; +Cc: kbuild-all, Greg Kroah-Hartman, devel, linux-kernel drivers/staging/i2o/iop.c:777:1-3: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Alan Cox <alan@linux.intel.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- iop.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/staging/i2o/iop.c +++ b/drivers/staging/i2o/iop.c @@ -774,11 +774,7 @@ static int i2o_iop_online(struct i2o_con /* In READY state */ osm_debug("%s: Attempting to enable...\n", c->name); - rc = i2o_iop_enable(c); - if (rc) - return rc; - - return 0; + return i2o_iop_enable(c); }; /** ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-30 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201504302132.UufsL5Kz%fengguang.wu@intel.com>
2015-04-30 13:03 ` [PATCH] i2o: fix semicolon.cocci warnings kbuild test robot
2015-04-30 14:12 ` Greg Kroah-Hartman
2015-04-30 13:03 ` [PATCH] i2o: fix simple_return.cocci warnings kbuild test robot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox