From: Ingo Molnar <mingo@kernel.org>
To: George Beshers <gbeshers@sgi.com>
Cc: Mike Travis <travis@sgi.com>,
linux-kernel@vger.kernel.org, Alex Thorlton <athorlton@sgi.com>,
Dimitri Sivanich <sivanich@sgi.com>,
Ingo Molnar <mingo@redhat.com>, Hedi Berriche <hedi@sgi.com>,
Russ Anderson <rja@sgi.com>
Subject: Re: [PATCH 1/2] UV: NMI: insert per_cpu accessor function on uv_hub_nmi.
Date: Fri, 1 May 2015 09:21:26 +0200 [thread overview]
Message-ID: <20150501072126.GC19852@gmail.com> (raw)
In-Reply-To: <20150430132914.28122.11850.sendpatchset@gulag2.americas.sgi.com>
* George Beshers <gbeshers@sgi.com> wrote:
> UV: NMI: insert this_cpu_read accessor function on uv_hub_nmi.
>
> UV NMI was accidently broken by this patch.
Broken in what way?
> commit e16321709c8270f9803bbfdb51e5e02235078c7f
> Author: Christoph Lameter <cl@linux.com>
> Date: Sun Aug 17 12:30:41 2014 -0500
That's a rather old patch. Was no upstream kernel tested since ~August
last year on UV hardware, or is the bug sporadic? The changelog does
not tell us.
> This patch insert this_cpu_read() on when accessing the PER_CPU
> uv_cpu_nmi variable.
Why? What problem does it solve?
Thanks,
Ingo
next prev parent reply other threads:[~2015-05-01 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 13:29 [PATCH 1/2] UV: NMI: insert per_cpu accessor function on uv_hub_nmi George Beshers
2015-04-30 13:29 ` [PATCH 2/2] UV: NMI: simple dump failover if kdump fails George Beshers
2015-05-01 7:27 ` Ingo Molnar
2015-05-01 16:33 ` Mike Travis
2015-05-01 16:42 ` Ingo Molnar
2015-05-01 7:21 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-13 2:51 [PATCH 1/2] UV: NMI: insert per_cpu accessor function on uv_hub_nmi George Beshers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501072126.GC19852@gmail.com \
--to=mingo@kernel.org \
--cc=athorlton@sgi.com \
--cc=gbeshers@sgi.com \
--cc=hedi@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=sivanich@sgi.com \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox